Skip to content

Add packages related to the LWA software stack#34112

Merged
becker33 merged 11 commits intospack:developfrom
downloadico:develop
Dec 5, 2022
Merged

Add packages related to the LWA software stack#34112
becker33 merged 11 commits intospack:developfrom
downloadico:develop

Conversation

@downloadico
Copy link
Copy Markdown
Contributor

Adding a few packages related to the LWA software stack

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Nov 23, 2022

Hi @downloadico! I noticed that the following package(s) don't yet have maintainers:

  • epsic
  • psrcat
  • psrchive
  • tempo

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["downloadico"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame epsic

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

Copy link
Copy Markdown
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the LWA-specific versions, do you know whether these are commonly used commits of the packages or just something specific to LWA?

@downloadico
Copy link
Copy Markdown
Contributor Author

I don't have any idea if the commits specified in these packages are used by anyone outside of the LWA stack.
:(

Copy link
Copy Markdown
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM now

@downloadico downloadico requested a review from becker33 December 2, 2022 19:36
@becker33 becker33 merged commit 85b6bf9 into spack:develop Dec 5, 2022
luke-dt pushed a commit to dantaslab/spack that referenced this pull request Dec 5, 2022
* epsic: add epsic package to spack

* psrcat: add psrcat to spack

* psrchive: add psarchive to spack

* tempo: add tempo package to spack
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
* epsic: add epsic package to spack

* psrcat: add psrcat to spack

* psrchive: add psarchive to spack

* tempo: add tempo package to spack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants