spack external find: library detection improvements#33973
Merged
alalazo merged 1 commit intospack:developfrom Nov 2, 2023
Merged
spack external find: library detection improvements#33973alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
spackbot-app
bot
added
core
haampie
force-pushed
the
fix/lib-search-paths
branch
from
125f7d2 to
7ce0e2e
Compare
alalazo
approved these changes
Nov 2, 2023
alalazo
reviewed
Nov 2, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third point is relevant for multi-arch distros, such as Ubuntu, where sometimes i686 directories have higher priority than x86_64. For executables we typically inspect
exe --versionwhich also ensures host-compatibility, so to me it makes sense if for libraries we verify "is the lib compatible with the Python interpreter we're currently running".This doesn't deal with static libraries, nor with Darwin.