Skip to content

ci: restore ability to reproduce gitlab job failures#33953

Merged
kwryankrattiger merged 1 commit intospack:developfrom
scottwittenburg:fix-ci-reproduce-build
Nov 21, 2022
Merged

ci: restore ability to reproduce gitlab job failures#33953
kwryankrattiger merged 1 commit intospack:developfrom
scottwittenburg:fix-ci-reproduce-build

Conversation

@scottwittenburg
Copy link
Copy Markdown
Contributor

@scottwittenburg scottwittenburg commented Nov 16, 2022

Now that the pipeline-generated install.sh script contains the absolute path to the directory containing the spack environment concretized during pipeline generation, we need to copy the spack.lock and spack.yaml artifacts when setting up the reproducer, so they can be found in the same absolute path.

@spackbot-app spackbot-app bot added the core PR affects Spack core functionality label Nov 16, 2022
Copy link
Copy Markdown
Contributor

@kwryankrattiger kwryankrattiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on a job I was working on, fixed for me too!

@haampie
Copy link
Copy Markdown
Member

haampie commented Nov 17, 2022

Thanks. I knew this was an issue but didn't get to it.

I was contemplating to also add -e <path> to the direct spack install step in install.sh, then reproducing is just two steps (source setup-env.sh and run install.sh) instead of three (spack env activate ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants