Skip to content

Add the very first version of cernlib package#33911

Merged
tldahlgren merged 4 commits intospack:developfrom
andriish:add_cernlib
Dec 5, 2022
Merged

Add the very first version of cernlib package#33911
tldahlgren merged 4 commits intospack:developfrom
andriish:add_cernlib

Conversation

@andriish
Copy link
Copy Markdown
Contributor

Add the very first version of cernlib package.
CERNLIB version : 2022.11.08.0 with cmake.

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor corrections requested.

@tldahlgren tldahlgren self-assigned this Nov 15, 2022
@tldahlgren
Copy link
Copy Markdown
Contributor

FYI. I am able to successfully build the package (with the suggested changes).

@andriish
Copy link
Copy Markdown
Contributor Author

andriish commented Dec 3, 2022

FYI. I am able to successfully build the package (with the suggested changes).

Thank you for testing!

@andriish
Copy link
Copy Markdown
Contributor Author

andriish commented Dec 5, 2022

Hi @tldahlgren ,

reformatted the script. The Ci should pass. Please have a look.

Best regards,

Andrii

@andriish andriish requested a review from tldahlgren December 5, 2022 11:55
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tldahlgren tldahlgren merged commit a7b5f2e into spack:develop Dec 5, 2022
luke-dt pushed a commit to dantaslab/spack that referenced this pull request Dec 5, 2022
* Add the very first version of cernlib
* Update package.py
* Update package.py

Co-authored-by: Andrii Verbytskyi <[email protected]>
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
* Add the very first version of cernlib
* Update package.py
* Update package.py

Co-authored-by: Andrii Verbytskyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants