Skip to content

Revert "fix perl libxcrypt.so dep"#33909

Merged
haampie merged 1 commit intospack:developfrom
blue42u:revert-perl-libxcrypt-dep
Nov 15, 2022
Merged

Revert "fix perl libxcrypt.so dep"#33909
haampie merged 1 commit intospack:developfrom
blue42u:revert-perl-libxcrypt-dep

Conversation

@blue42u
Copy link
Copy Markdown
Contributor

@blue42u blue42u commented Nov 15, 2022

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Nov 15, 2022

Hi @blue42u! I noticed that the following package(s) don't yet have maintainers:

  • perl

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["blue42u"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame perl

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@haampie
Copy link
Copy Markdown
Member

haampie commented Nov 15, 2022

@haampie
Copy link
Copy Markdown
Member

haampie commented Nov 15, 2022

Will accept for now, since CI is ... green.

But at the end of the day this is not a solution, just a slightly less worse problem.

@haampie haampie merged commit 850c54c into spack:develop Nov 15, 2022
@blue42u blue42u deleted the revert-perl-libxcrypt-dep branch November 15, 2022 15:00
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
This reverts commit bf1b2a8, as libxcrypt's configure script requires Perl, leading to a circular dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants