Merged
Conversation
* develop: (85 commits) Make libxcb compile with gcc 4.9. disable parallel install for glib (found races) disable cairo-trace, which is incompatible with older libiberty.h. Fix LaunchMon on newer gcc versions. Simplify output redirection in spack.util.executable Allow completely empty config files. Update cmake package to use http in all URLs. Fix create, diy, edit, and repo commands to use multiple repos. Add namespace option to find command. Temporary fix: Clang is the default compiler on Mac OS X. Netcdf requires cmake >=2.8.12 Mbedtls depends on cmake Update libtool to 2.4.6 Update Julia to 0.4.3 Make binutils build on OS X Add verbs and psm variants py-matplotlib: depend on freetype py-numpy: make blas/lapack optional dependencies qhull: apply patch to work with libc++'s standard library New package GNU tar ...
Member
Author
|
Do you think SZip should be a variant? Some of the configure options I chose are enabled by default. I'm not sure if there's any consensus on whether or not to include options that are already enabled. |
Member
|
Making it a variant is generally useful. You can make it default to enabled, and then the user can at least request that it be disabled if they can't build with it for some reason. |
Member
|
Looks good! FYI: I don't get notifications when you push commits, even though they show up on the PR. If you want me to get to it faster add a comment. I wish I knew how to add notifications for additional commits. |
matz-e
pushed a commit
to matz-e/spack
that referenced
this pull request
Apr 27, 2020
climbfuji
added a commit
to climbfuji/spack
that referenced
this pull request
Oct 6, 2023
Bug fix for py-awscrt on Linux (use spack openssl/libcrypto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is for HDF4. Currently there is only an HDF5 package. Note that the source code, as well as my package, are named HDF instead of HDF4.
Possible bugs:
spack versions hdfdoes not find any Remote versions. However, this could be said about a lot of packages that have sites with weird naming conventions.spack fetch hdf@<version>works just fine, so I don't think it's a problem.