py-alphafold: update to 2.2.4, update dependencies#33876
py-alphafold: update to 2.2.4, update dependencies#33876adamjstewart merged 2 commits intospack:developfrom
Conversation
spackbot-app
bot
added
dependencies
new-package
new-variant
new-version
python
update-package
labels
|
Hi @aweits! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers = ["aweits"]If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame openmmThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
|
Can you try enabling jax in CI? Just uncomment in |
spackbot-app
bot
added
core
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Protobuf changes look a little sus. Most other changes are prob right but I don't see where you're getting the dependency version ranges from so it's hard to review. Can you add comments to those packages whenever it isn't as simple as checking the root setup.py file for a list of deps?
aweits
force-pushed
the
alphafold_update
branch
from
94ed394 to
6c4415a
Compare
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Mostly meta comments and non-required suggestions, I think this is basically good to go.
| remove_linked_tree(self.tmp_path) | ||
| remove_linked_tree(self.buildtmp) | ||
|
|
||
| def patch(self): |
There was a problem hiding this comment.
Any reason to drop the patch method? I think it helps to logically separate patching from installation. Unless the multi-build system refactor broke this somehow.
There was a problem hiding this comment.
the multi-build system has yielded some surprising behavior here - not sure I like this solution, but see all the references to "wrapped_package_object" perhaps @alalazo has some words of wisdom?
aweits
force-pushed
the
alphafold_update
branch
2 times, most recently
from
19a6819 to
1a366c4
Compare
|
any objection to merging as-is? |
|
We need to get CI passing first. Either rebase or keep pinging spackbot to rerun the pipeline |
aweits
force-pushed
the
alphafold_update
branch
from
1a366c4 to
e62819a
Compare
* py-alphafold: update to 2.2.4, update dependencies * style
* py-alphafold: update to 2.2.4, update dependencies * style
2 participants
No description provided.