@srekolam, @haampie, @renjithravindrankannath: I will need to rebase this on ROCm 5.3 but do you have any thoughts on my suggestions in this PR? I imagine that adding +rocm and +cuda to the hip package might be a big deal, so perhaps that should be an independent PR.

It would be nice for hip{BLAS,SOLVER,SPARSE,FFT,RAND} to inherit from ROCmPackage like the various higher-level libraries do. If nothing else, it will give them the amdgpu_target variant. Changing them to inherit from CudaPackage and supporting the +cuda variant might have to wait until that hypothetical hip +cuda PR goes in, so maybe that means splitting this change into three PRs: CUDA support for the hip package, inheriting from ROCmPackage in the hip mathlibs, and inheriting from CudaPackage in the hip mathlibs.

@cgmb , the initial ask was to add the cuda support for the hip package issue (#26898) . i do agree with your other suggestion for mathlibs of inheriting from the ROCmPackage. Perhaps we can do this in multiple PRs but if we can get to support the +cuda inside the hip package , it would help .

Ok. I've turned this PR into the change to the hip package and split the updates to the mathlibs off into #34586. This change introduces the +rocm and +cuda variants into the HIP package.

I mostly left the current logic unchanged for +rocm, but had to guard it behind an if/else. The diff for this PR is a lot easier to review if you check the 'Hide whitespace' button.

@spackbot rerun pipeline

I've started that pipeline for you!

@spackbot rerun pipeline

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Unexpected response from gitlab: {'message': '404 Commit Not Found'}

@srekolam, @haampie, @renjithravindrankannath, this change is ready for review.

@srekolam, @haampie, @renjithravindrankannath:

Please review these changes. If the diff is a bit overwhelming, try using the "Hide whitespace" option (the checkbox for which is behind the gear on the Files changed tab). The changes required to add CUDA support are actually quite small.

@spackbot rerun pipeline

I've started that pipeline for you!

@srekolam, @haampie, @renjithravindrankannath: I've fixed the merge conflicts, please take a look..

Looks good to me.

@haampie: all checks have passed and the maintainers have approved. Could you review and/or merge?

@cgmb Thank you very much.