remove deprecated concretization environment key#33774
Merged
Conversation
spackbot-app
bot
added
commands
core
tgamblin
changed the title
tgamblin
changed the title
concretization environment key
tgamblin
previously approved these changes
Nov 9, 2022
Member
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
lib/spack/spack/environment/environment.py
lib/spack/spack/schema/env.py
lib/spack/spack/test/cmd/env.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 569 source files
mypy checks were clean
==> Running black checks
All done! ✨ 🍰 ✨
3 files left unchanged.
black checks were clean
==> Running flake8 checks
lib/spack/spack/schema/env.py:11: [F401] 'warnings' imported but unused
flake8 found errors
I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally! |
tgamblin
approved these changes
Nov 10, 2022
tgamblin
deleted the
deprecations/remove-deprecated-concretization-together
branch
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Nov 11, 2022
trws
pushed a commit
to trws/spack
that referenced
this pull request
Nov 11, 2022
charmoniumQ
pushed a commit
to charmoniumQ/spack
that referenced
this pull request
Nov 19, 2022
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation message added in v0.18.0, listed v0.19.0 as the version it would be removed fully.