ParaView: ParaView needs to set the HDF5 API by kwryankrattiger · Pull Request #33617 · spack/spack

kwryankrattiger · 2022-10-31T13:06:20Z

When building ParaView with a newer HDf5 than 1.10, it needs to select the 1.10 API using flags.

tldahlgren

Suggest switching to use of satisfies() when checking version ranges of specs. See https://spack.readthedocs.io/en/latest/packaging_guide.html#testing-spec-constraints.

var/spack/repos/builtin/packages/paraview/package.py

mathstuf

Looks fine to me after how to spell the logic gets hammered out. Note that VTK should probably just do this on its own in the VTK::hdf5 module logic…

tldahlgren

Thanks. LGTM.

tldahlgren · 2022-10-31T21:26:08Z

@spackbot fix style

spackbot-app · 2022-10-31T21:26:11Z

Let me see if I can fix that for you!

When building ParaView with a newer HDf5 than 1.10, it needs to select the 1.10 API using flags.

spackbot-app · 2022-10-31T21:27:50Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, mypy, black, flake8
==> Modified files
  var/spack/repos/builtin/packages/paraview/package.py
==> Running isort checks
  isort checks were clean
==> Running mypy checks
Success: no issues found in 562 source files
  mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/paraview/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

- When +hdf5, enable VOL adapters suitable for the SDK. - Each VOL package must prepend to the HDF5_PLUGIN_PATH. - hdf5: 1.13.3 will break existing VOL packages, constrain VOLs related to SDK and add note to keep 1.13.2 available. - hdf5-vol-async: - Do not set HDF5_VOL_CONNECTOR, consumers must opt-in. - Enforce DAG constraints on MPI to require threaded version. - Depend on an explicit version of argbots to relax concretization issues in other spack environments. - paraview: use the 112 ABI (followup to spack#33617). [test] Paraview needs to use the hdf5 112 ABI

- When +hdf5, enable VOL adapters suitable for the SDK. - Each VOL package must prepend to the HDF5_PLUGIN_PATH. - hdf5: 1.13.3 will break existing VOL packages, constrain VOLs related to SDK and add note to keep 1.13.2 available. - hdf5-vol-async: - Do not set HDF5_VOL_CONNECTOR, consumers must opt-in. - Enforce DAG constraints on MPI to require threaded version. - Depend on an explicit version of argbots to relax concretization issues in other spack environments. - paraview: use the 112 ABI (followup to spack#33617).

- When +hdf5, enable VOL adapters suitable for the SDK. - Each VOL package must prepend to the HDF5_PLUGIN_PATH. - hdf5: 1.13.3 will break existing VOL packages, constrain VOLs related to SDK and add note to keep 1.13.2 available. - hdf5-vol-async: - Do not set HDF5_VOL_CONNECTOR, consumers must opt-in. - Enforce DAG constraints on MPI to require threaded version. - Depend on an explicit version of argbots to relax concretization issues in other spack environments. - paraview: fix compiler flag usage for the 110 ABI (followup to spack#33617).

When building ParaView with a newer HDf5 than 1.10, it needs to select the 1.10 API using flags.

- When +hdf5, enable VOL adapters suitable for the SDK. - Each VOL package must prepend to the HDF5_PLUGIN_PATH. - hdf5: 1.13.3 will break existing VOL packages, constrain VOLs related to SDK and add note to keep 1.13.2 available. - hdf5-vol-async: - Do not set HDF5_VOL_CONNECTOR, consumers must opt-in. - Enforce DAG constraints on MPI to require threaded version. - Depend on an explicit version of argbots to relax concretization issues in other spack environments. - paraview: fix compiler flag usage for the 110 ABI (followup to spack#33617).

* ECP-SDK: enable hdf5 VOL adapters - When +hdf5, enable VOL adapters suitable for the SDK. - Each VOL package must prepend to the HDF5_PLUGIN_PATH. - hdf5: 1.13.3 will break existing VOL packages, constrain VOLs related to SDK and add note to keep 1.13.2 available. - hdf5-vol-async: - Do not set HDF5_VOL_CONNECTOR, consumers must opt-in. - Enforce DAG constraints on MPI to require threaded version. - Depend on an explicit version of argbots to relax concretization issues in other spack environments. - paraview: fix compiler flag usage for the 110 ABI (followup to #33617). * ECP Data and ViS: Add constraits for HDF5 VOLS * CI: HDF5 1.14 builds without VisIt * hdf5-vol-async: Update docs string --------- Co-authored-by: Stephen McDowell <[email protected]>

kwryankrattiger requested review from mathstuf and vicentebolea October 31, 2022 13:06

spackbot-app bot added the update-package label Oct 31, 2022

spackbot-app bot requested review from chuckatkins and danlipsa October 31, 2022 13:06

eugeneswalker added the e4s label Oct 31, 2022

tldahlgren reviewed Oct 31, 2022

View reviewed changes

var/spack/repos/builtin/packages/paraview/package.py Outdated Show resolved Hide resolved

var/spack/repos/builtin/packages/paraview/package.py Outdated Show resolved Hide resolved

tldahlgren self-assigned this Oct 31, 2022

mathstuf previously approved these changes Oct 31, 2022

View reviewed changes

kwryankrattiger dismissed mathstuf’s stale review via 9cb3391 October 31, 2022 18:30

kwryankrattiger force-pushed the paraview_select_hdf5_api branch from e081fa1 to 9cb3391 Compare October 31, 2022 18:30

tldahlgren previously approved these changes Oct 31, 2022

View reviewed changes

ParaView: ParaView needs to set the HDF5 API

e38711d

When building ParaView with a newer HDf5 than 1.10, it needs to select the 1.10 API using flags.

spackbot dismissed tldahlgren’s stale review via e38711d October 31, 2022 21:27

kwryankrattiger force-pushed the paraview_select_hdf5_api branch from dc3d609 to e38711d Compare October 31, 2022 21:27

tldahlgren assigned mathstuf Oct 31, 2022

tldahlgren approved these changes Oct 31, 2022

View reviewed changes

tldahlgren enabled auto-merge (squash) October 31, 2022 21:57

tldahlgren merged commit 6b86a85 into spack:develop Nov 1, 2022

svenevs mentioned this pull request Nov 3, 2022

ECP-SDK: enable hdf5 VOL adapters #33393

Closed

6 tasks

charmoniumQ pushed a commit to charmoniumQ/spack that referenced this pull request Nov 19, 2022

ParaView: ParaView needs to set the HDF5 API (spack#33617)

0bc3161

When building ParaView with a newer HDf5 than 1.10, it needs to select the 1.10 API using flags.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ParaView: ParaView needs to set the HDF5 API#33617

ParaView: ParaView needs to set the HDF5 API#33617
tldahlgren merged 1 commit intospack:developfrom
kwryankrattiger:paraview_select_hdf5_api

kwryankrattiger commented Oct 31, 2022

Uh oh!

tldahlgren left a comment

Uh oh!

Uh oh!

Uh oh!

mathstuf left a comment

Uh oh!

tldahlgren left a comment

Uh oh!

tldahlgren commented Oct 31, 2022

Uh oh!

spackbot-app bot commented Oct 31, 2022

Uh oh!

spackbot-app bot commented Oct 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kwryankrattiger commented Oct 31, 2022

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mathstuf left a comment

Choose a reason for hiding this comment

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

tldahlgren commented Oct 31, 2022

Uh oh!

spackbot-app bot commented Oct 31, 2022

Uh oh!

spackbot-app bot commented Oct 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants