Skip to content

oce: rework recipe to prefer old intel-tbb#33553

Merged
alalazo merged 1 commit intospack:developfrom
alalazo:packages/oce
Oct 27, 2022
Merged

oce: rework recipe to prefer old intel-tbb#33553
alalazo merged 1 commit intospack:developfrom
alalazo:packages/oce

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Oct 27, 2022

No description provided.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Oct 27, 2022

Hi @alalazo! I noticed that the following package(s) don't yet have maintainers:

  • oce

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["alalazo"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame oce

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Oct 27, 2022

@luca-heltai @balay This PR and #33550 together should bring back intel-tbb into dealii concretization (I'm referring to #30738 (comment)) That said I think oce is outdated and we should probably use opencascade as a dependency. Did any of you already try that?

@balay
Copy link
Copy Markdown
Contributor

balay commented Oct 27, 2022

[balay@pj01 spack]$ ./bin/spack  spec dealii%[email protected] |grep intel-
        ^[email protected]%[email protected]~advisor~clck+daal~gdb~ilp64~inspector+ipp~itac+mkl+mpi~newdtags+rpath+shared+tbb~vtune auto_dispatch=none build_system=generic threads=none arch=linux-fedora37-skylake
[balay@pj01 spack]$ patch -Np1 < 33553.patch 
patching file var/spack/repos/builtin/packages/oce/package.py
[balay@pj01 spack]$ ./bin/spack  spec dealii%[email protected] |grep intel-
            ^[email protected]%[email protected]+shared+tm build_system=makefile cxxstd=default patches=62ba015,ce1fb16,d62cb66 arch=linux-fedora37-skylake

So this PR does help. Thanks!

also cc: @bangerth

@alalazo alalazo merged commit 9a51d42 into spack:develop Oct 27, 2022
@alalazo alalazo deleted the packages/oce branch October 27, 2022 13:34
becker33 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2022
charmoniumQ pushed a commit to charmoniumQ/spack that referenced this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants