Skip to content

locks: improved errors#33477

Merged
haampie merged 3 commits intospack:developfrom
haampie:fix/better-lock-messages
Oct 24, 2022
Merged

locks: improved errors#33477
haampie merged 3 commits intospack:developfrom
haampie:fix/better-lock-messages

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Oct 23, 2022

Instead of showing

==> Error: Timed out waiting for a write lock.

show

==> Error: Timed out waiting for a write lock after 1.200ms and 4 attempts on file: /some/file

s.t. we actually get to see where acquiring a lock failed even when not
running in debug mode.

And use pretty time units everywhere, so we don't get 1.45e-9 seconds
but 1.450ns etc.

Instead of showing

```
==> Error: Timed out waiting for a write lock.
```

show

```
==> Error: Timed out waiting for a write lock after 1.200ms and 4 attempts on file: /some/file
```

s.t. we actually get to see where acquiring a lock failed even when not
running in debug mode.

And use pretty time units everywhere, so we don't get 1.45e-9 seconds
but 1.450ns etc.
@spackbot-app spackbot-app bot added core PR affects Spack core functionality locking tests General test capability(ies) utilities labels Oct 23, 2022
@haampie
Copy link
Copy Markdown
Member Author

haampie commented Oct 23, 2022

@cosmicexplorer friendly reminder to fix your test_grouped_exception test 😬

@haampie
Copy link
Copy Markdown
Member Author

haampie commented Oct 23, 2022

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Oct 23, 2022

I've started that pipeline for you!

Copy link
Copy Markdown
Member

@tgamblin tgamblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- minor request

@haampie haampie merged commit d67b12e into spack:develop Oct 24, 2022
@haampie haampie deleted the fix/better-lock-messages branch October 24, 2022 09:54
becker33 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2022
Instead of showing

```
==> Error: Timed out waiting for a write lock.
```

show

```
==> Error: Timed out waiting for a write lock after 1.200ms and 4 attempts on file: /some/file
```

s.t. we actually get to see where acquiring a lock failed even when not
running in debug mode.

And use pretty time units everywhere, so we don't get 1.45e-9 seconds
but 1.450ns etc.
charmoniumQ pushed a commit to charmoniumQ/spack that referenced this pull request Nov 19, 2022
Instead of showing

```
==> Error: Timed out waiting for a write lock.
```

show

```
==> Error: Timed out waiting for a write lock after 1.200ms and 4 attempts on file: /some/file
```

s.t. we actually get to see where acquiring a lock failed even when not
running in debug mode.

And use pretty time units everywhere, so we don't get 1.45e-9 seconds
but 1.450ns etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality locking tests General test capability(ies) utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants