Skip to content

FIX CI after git update#33429

Merged
alalazo merged 2 commits intospack:developfrom
alalazo:qa/git_fix_ci
Oct 20, 2022
Merged

FIX CI after git update#33429
alalazo merged 2 commits intospack:developfrom
alalazo:qa/git_fix_ci

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Oct 20, 2022

We use local repositories in unit-tests to stress some git related functionality. The default value of protocol.file.allow after CVE-2022-39253 conflicts with our fixtures. Here we restore the previous default value.

Modifications:

  • Add protocol.file.allow always to our git configuration in CI

@spackbot-app spackbot-app bot added core PR affects Spack core functionality workflow labels Oct 20, 2022
alalazo
alalazo commented Oct 20, 2022
View reviewed changes
@alalazo alalazo requested a review from haampie October 20, 2022 06:53
@alalazo alalazo added the ci Issues related to Continuous Integration label Oct 20, 2022
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Oct 20, 2022

For the record, this is the current state for the pipeline I am waiting for in develop to finish:
Screenshot from 2022-10-20 09-42-19

Since the changes here cannot affect at all pipelines, but they should solve issues with CI, I'm going to merge them.

@alalazo alalazo merged commit 89cf500 into spack:develop Oct 20, 2022
@alalazo alalazo deleted the qa/git_fix_ci branch October 20, 2022 07:46
@alalazo alalazo mentioned this pull request Oct 20, 2022
Merged
tgamblin added a commit that referenced this pull request Dec 26, 2022
@tgamblin
Consolidate how Spack uses git
8d8508c 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git
2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in #33429, but that doesn't help the issue for anyone's local
environment. Instead of fixing this with git config in CI, we should ensure that the
tests run anywhere.

- [x] Introduce `spack.util.git`
- [x] Use `spack.util.git.get_git()` to get a git executable
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`
tgamblin added a commit that referenced this pull request Dec 26, 2022
@tgamblin
Consolidate how Spack uses git
cf1bb9a 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git
2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in #33429, but that doesn't help the issue for anyone's local
environment. Instead of fixing this with git config in CI, we should ensure that the
tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a git executable.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from #33429, which are no longer needed.
@tgamblin tgamblin mentioned this pull request Dec 26, 2022
Merged
5 tasks
tgamblin added a commit that referenced this pull request Dec 26, 2022
@tgamblin
Consolidate how Spack uses git
e5153a8 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git
2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in #33429, but that doesn't help the issue for anyone's local
environment. Instead of fixing this with git config in CI, we should ensure that the
tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a `git` executable, instead of
      using `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from #33429, which are no longer needed.
tgamblin added a commit that referenced this pull request Dec 26, 2022
@tgamblin
Consolidate how Spack uses git
63448f4 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git
2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in #33429, but that doesn't help the issue for anyone's local
environment. Instead of fixing this with git config in CI, we should ensure that the
tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a `git` executable, instead of
      using `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from #33429, which are no longer needed.
tgamblin added a commit that referenced this pull request Dec 27, 2022
@tgamblin
Consolidate how Spack uses git
f65921b 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git
2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in #33429, but that doesn't help the issue for anyone's local
environment. Instead of fixing this with git config in CI, we should ensure that the
tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a `git` executable, instead of
      using `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from #33429, which are no longer needed.
tgamblin added a commit that referenced this pull request Dec 27, 2022
@tgamblin
Consolidate how Spack uses git
4238f49 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git
2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in #33429, but that doesn't help the issue for anyone's local
environment. Instead of fixing this with git config in CI, we should ensure that the
tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a `git` executable, instead of
      using `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from #33429, which are no longer needed.
tgamblin added a commit that referenced this pull request Dec 28, 2022
@tgamblin
Consolidate how Spack uses git (#34700)
5f8c706 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in #33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from #33429, which are no longer needed.
stephenmsachs pushed a commit to stephenmsachs/spack that referenced this pull request Jan 3, 2023
@tgamblin
Consolidate how Spack uses git (spack#34700)
8c614c5 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from spack#33429, which are no longer needed.
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 24, 2023
@tgamblin @RikkiButler20
Consolidate how Spack uses git (spack#34700)
92dbf31 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from spack#33429, which are no longer needed.
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
@tgamblin
Consolidate how Spack uses git (spack#34700)
fa33d7d 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from spack#33429, which are no longer needed.
techxdave pushed a commit to Tech-XCorp/spack that referenced this pull request Feb 17, 2023
@tgamblin @techxdave
Consolidate how Spack uses git (spack#34700)
53ec038 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from spack#33429, which are no longer needed.
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
@tgamblin @jmcarcell
Consolidate how Spack uses git (spack#34700)
dbd117a 
Local `git` tests will fail with `fatal: transport 'file' not allowed` when using git 2.38.1 or higher, due to a fix for `CVE-2022-39253`.

This was fixed in CI in spack#33429, but that doesn't help the issue for anyone's local environment. Instead of fixing this with git config in CI, we should ensure that the tests run anywhere.

- [x] Introduce `spack.util.git`.
- [x] Use `spack.util.git.get_git()` to get a git executable, instead of `which("git")` everywhere.
- [x] Make all `git` tests use a `git` fixture that goes through `spack.util.git.get_git()`.
- [x] Add `-c protocol.file.allow=always` to all `git` invocations under `pytest`.
- [x] Revert changes from spack#33429, which are no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haampie haampie Awaiting requested review from haampie

Assignees

No one assigned

Labels

ci Issues related to Continuous Integration core PR affects Spack core functionality workflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alalazo