env depfile: allow deps only install#33245
Merged
trws merged 2 commits intospack:developfrom Oct 12, 2022
Merged
Conversation
- Refactor `spack env depfile` to use a Jinja template, making it a bit easier to follow as a human being. - Add a layer of indirection in the generated Makefile through an `<prefix>/.install-deps/<hash>` target, which allows one to specify different options when installing dependencies. For example, only verbose/debug mode on when installing some particular spec: ``` $ spack -e my_env env depfile -o Makefile --make-target-prefix example $ make example/.install-deps/<hash> -j16 $ make example/.install/<hash> SPACK="spack -d" SPACK_INSTALL_FLAGS=--verbose -j16 ``` This could be used to speed up `spack ci rebuild`: - Parallel install of dependencies from buildcache - Better readability of logs, e.g. reducing verbosity when installing dependencies, and splitting logs into deps.log and current_spec.log
trws
reviewed
Oct 12, 2022
| import llnl.util.lang | ||
|
|
||
| import spack.config | ||
| import spack.extensions |
Member
Author
There was a problem hiding this comment.
I noticed it was a missing import -- I can drop it from this PR to keep the squash commit on develop clean if you want
Contributor
There was a problem hiding this comment.
Nah, if it's missing leave it.
trws
approved these changes
Oct 12, 2022
Contributor
trws
left a comment
trws
left a comment
There was a problem hiding this comment.
Pending whether that import is necessary, I'm happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spack env depfileto use a Jinja template, making it a biteasier to follow as a human being.
<prefix>/.install-deps/<hash>target, which allows one to specifydifferent options when installing dependencies. For example, only
verbose/debug mode on when installing some particular spec:
This could be used to speed up
spack ci rebuild:dependencies, and splitting logs into deps.log and current_spec.log
Given that
spack ci rebuildis already unix only and make is a required spack dep... I think it's worth doing this.