Skip to content

py-pythran: customize headers attribute#33242

Merged
haampie merged 3 commits intospack:developfrom
alalazo:fixes/pythran_and_co
Oct 12, 2022
Merged

py-pythran: customize headers attribute#33242
haampie merged 3 commits intospack:developfrom
alalazo:fixes/pythran_and_co

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Oct 12, 2022

Fixes py-scipy build in gitlab (see #33237 for details)

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Oct 12, 2022

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Oct 12, 2022

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Oct 12, 2022

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, mypy, black, flake8
==> Modified files
  var/spack/repos/builtin/packages/py-pythran/package.py
==> Running isort checks
  isort checks were clean
==> Running mypy checks
Success: no issues found in 556 source files
  mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-pythran/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with isort fixes.

@haampie
Copy link
Copy Markdown
Member

haampie commented Oct 12, 2022

I've updated the description so that we don't close #33237, since this issue of long strings in env variables can pop up in general

haampie
haampie previously approved these changes Oct 12, 2022
@haampie haampie enabled auto-merge (squash) October 12, 2022 12:14
adamjstewart
adamjstewart previously approved these changes Oct 12, 2022
@alalazo alalazo dismissed stale reviews from adamjstewart and haampie via 3cd68c3 October 12, 2022 12:45
@haampie
Copy link
Copy Markdown
Member

haampie commented Oct 12, 2022

uh, similar issues in ci?

@adamjstewart
Copy link
Copy Markdown
Member

That py-torch-geometric test really doesn't want to finish. Do we wait for the 6 hr timeout or boot it?

@haampie haampie merged commit 48da17d into spack:develop Oct 12, 2022
@alalazo alalazo deleted the fixes/pythran_and_co branch October 12, 2022 19:10
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Oct 12, 2022

We need to do something to speed-up relocation. 3hrs to relocate binaries is a bit too much

@haampie
Copy link
Copy Markdown
Member

haampie commented Oct 12, 2022

@alalazo it's your lucky day: #33248 (assuming you meant that installing dependencies is slow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants