py-poetry-core: jail git to stage directory#33181
Merged
alalazo merged 1 commit intospack:developfrom Oct 12, 2022
Merged
Conversation
Contributor
|
It looks like it builds normally for me |
36feb09 to
da1f1b8
Compare
alalazo
approved these changes
Oct 12, 2022
Contributor
|
@adamjstewart I didn't get to test this before it got merged, but I just cherry-picked the change and it works like a charm. Thanks a lot! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See python-poetry/poetry#5547 for discussion of the bug that this PR works around.
Fixes #32375 @skosukhin
Fixes #29308 @climbfuji
Fixes #32936 (comment) @luke-dt
Can everyone test this to ensure that it works?
Should this be done for all packages in Spack? I can imagine other packages whose build behavior changes depending on how far git recurses up the build tree. But I'm not sure where in
build_environment.pyto put this.Are there any possible issues with this approach? What if someone is behind a firewall and requires proxy stuff that is in their global git configuration file?