Add checksum for py-virtualenv 20.16.4#33154
Merged
adamjstewart merged 4 commits intospack:developfrom Oct 11, 2022
Merged
Conversation
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
var/spack/repos/builtin/packages/py-virtualenv/package.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 558 source files
mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-virtualenv/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
I've updated the branch with isort fixes. |
Contributor
Author
|
Can I ask for #33047 to be merged now, since this PR kind of depends on it? |
adamjstewart
requested changes
Oct 10, 2022
adamjstewart
approved these changes
Oct 10, 2022
Member
|
@alalazo this PR was failing audit tests (missing dep version) but still auto-merged. Any idea what happened here? |
Member
|
Btw, if #33047 ever passes CI, this issue will be solved in develop. |
Member
|
Are our audit tests not required for CI to pass? |
Member
|
They should be, let me check |
luke-dt
pushed a commit
to dantaslab/spack
that referenced
this pull request
Oct 12, 2022
* Add checksum for py-virtualenv 20.16.4 * [@spackbot] updating style on behalf of iarspider * Update package.py * Update package.py Co-authored-by: iarspider <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.