PythonPackage: fix libs/headers attributes#32970
Merged
alalazo merged 3 commits intospack:developfrom Oct 10, 2022
Merged
Conversation
spackbot-app
bot
added
build-systems
core
spackbot-app
bot
requested review from
MakisH,
RemiLacroix-IDRIS,
fsimonis and
pradyunsg
cosmicexplorer
suggested changes
Oct 4, 2022
alalazo
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that was introduced in #28527. See #28527 (comment) for a detailed breakdown of the problem, and #32835 (comment) for the proposed fix. Still curious why the previous code didn't work, and didn't error, but I'm happy with the solution.
Also fixes a few instances where we were manually searching for this directory instead of relying on this attribute: #32835 (comment)
Reverts #31446
Closes #32835
@cosmicexplorer @alalazo