octave: fix missing include <ctime>#32937
Closed
manuelakuhn wants to merge 1 commit intospack:developfrom
Closed
Conversation
siko1056
suggested changes
Oct 1, 2022
Contributor
siko1056
left a comment
siko1056
left a comment
There was a problem hiding this comment.
This problem is fixed with Octave 7.2.0
Unfortunately, Octave 7.2.0 is not yet present in Spack. I will add Octave 7.2.0 this weekend.
Do you agree @manuelakuhn to update to Octave 7.2.0 and avoid this patch?
I am sorry for the inconvenience.
Member
Author
|
Sure, if you update octave that is also fine with me. |
Contributor
|
Thank you for your patience, see #32943 and I kindly close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not install octave due to this bug.
This PR adds the patch to fix it.