simgrid: add variant and remove flag#32797
Merged
tldahlgren merged 2 commits intospack:developfrom Oct 3, 2022
llnns:simgrid_variant
Merged
simgrid: add variant and remove flag#32797tldahlgren merged 2 commits intospack:developfrom llnns:simgrid_variant
tldahlgren merged 2 commits intospack:developfrom
llnns:simgrid_variant
Conversation
tldahlgren
approved these changes
Sep 23, 2022
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
LGTM. Will defer merge decision until maintainer has a chance to comment.
| if spec.satisfies("+mc"): | ||
| args.append("-Denable_model-checking=ON") | ||
|
|
||
| if spec.satisfies("+msg"): |
Contributor
There was a problem hiding this comment.
I realize the pattern is already established in this package, but did you know there are built-in methods that can help set cmake arguments from variants? Check out https://spack.readthedocs.io/en/latest/build_systems/cmakepackage.html#adding-flags-to-cmake.
Contributor
There was a problem hiding this comment.
You can see more on define and define_from_variant starting at https://spack.readthedocs.io/en/latest/spack.build_systems.html?highlight=cmakepackage#spack.build_systems.cmake.CMakePackage.define.
viniciusvgp
approved these changes
Sep 23, 2022
Contributor
Author
|
Hello, maybe the pipeline needs to run again? |
viniciusvgp
approved these changes
Sep 30, 2022
Contributor
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
luke-dt
pushed a commit
to dantaslab/spack
that referenced
this pull request
Oct 4, 2022
* simgrid: remove std c++11 flag * simgrid: add msg variant
adamjstewart
added a commit
that referenced
this pull request
Oct 8, 2022
…(py-dendropy, py-phylophlan, py-pkgconfig) (#32936) * added metaphlan v4, cleaned up phylophlan * added iqtree2 * fixed phylophlan, builds now * changed config.yaml to default * fixed style * py-jsonschema: add 4.16.0 and new package py-hatch-fancy-pypi-readme (#32929) * acfl: add v22.1 (#32915) Co-authored-by: Annop Wongwathanarat <[email protected]> * Fixup errors introduced by Clingo Pr: (#32905) * re2c depends on cmake on Windows * Winbison properly added to bootstrap package search list * Set CMAKE_HIP_ARCHITECTURES with the value of amdgpu_target (#32901) * libtiff: default to +zlib+jpeg (#32945) * octave: add version 7.2.0 (#32943) * simgrid new releases (#32920) * [rocksdb] Added rtti variant (#32918) * rvs binary path updated for 5.2 rocm release (#32892) * Add checksum for py-pytest-runner 6.0.0 (#32957) * py-einops: add v0.5.0 (#32959) * Replace repo with the NVIDIA one (#32951) * Add checksum for py-tomli 2.0.1 (#32949) * QMCPACK: add @3.15.0 (#32931) * Tidied up configure arguments to use special spack autotools features. (#32930) * casper: old domain fell off, adding github repo (#32928) * unifyfs: pin mercury version; add boost variant (#32911) Mercury has a new version (v2.2) releasing soon that UnifyFS does not build with and hasn't been tested with. This pins UnifyFS to the last version of Mercury used/tested. Add a variant to avoid building/using boost Append -std=gnu99 to cflags if building with gcc@4. Needed for mochi-margo to compile * trilinos: constrain superlu-dist version (#32889) * trilinos: constrain superlu-dist version for 13.x * syntax * FEniCSx: Updates for 0.5.1 (#32665) * Updates for DOLFINx 0.5.1 and associated packages * xtensor needed on anything less than main * Switch back to Python 3.7 minimum. * Might be good to point out in our README how to fix Python version? * Fix basix, xtensor dep * Add numba feature * Fix checksum * Make slepc optional Co-authored-by: Tamara Dahlgren <[email protected]> * simgrid: add variant and remove flag (#32797) * simgrid: remove std c++11 flag * simgrid: add msg variant * Axom: bring in changes from axom repo (#32643) * bring in changes from axom repo Co-authored-by: white238 <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]> * Add checksum for py-pyparsing 3.0.9 (#32952) * rdma-core: fix syntax for external discoverability (#32962) * Add checksum for py-flatbuffers 2.0.7 (#32955) * amrex: add v22.10 (#32966) * Remove CMakePackage.define alias from most packages (#32950) * Bug fix for `ca-certificates-mozilla/package.py` to enable `spack install --source` (#32953) * made suggested changes to iqtree2, py-dendropy, py-metaphlan, and py-pkgconfig. Poetry install still broken * reverted py-pkgconfig deps to poetry-core * made iqtree2 less dedundant, changes to py-dendropy and py-pkgconfig deps Co-authored-by: Manuela Kuhn <[email protected]> Co-authored-by: Annop Wongwathanarat <[email protected]> Co-authored-by: Annop Wongwathanarat <[email protected]> Co-authored-by: John W. Parent <[email protected]> Co-authored-by: Auriane R <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]> Co-authored-by: Kai Torben Ohlhus <[email protected]> Co-authored-by: Vinícius <[email protected]> Co-authored-by: Matthieu Dorier <[email protected]> Co-authored-by: renjithravindrankannath <[email protected]> Co-authored-by: iarspider <[email protected]> Co-authored-by: Paul R. C. Kent <[email protected]> Co-authored-by: Brian Van Essen <[email protected]> Co-authored-by: snehring <[email protected]> Co-authored-by: Cameron Stanavige <[email protected]> Co-authored-by: Cody Balos <[email protected]> Co-authored-by: Jack S. Hale <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]> Co-authored-by: Lucas Nesi <[email protected]> Co-authored-by: Chris White <[email protected]> Co-authored-by: white238 <[email protected]> Co-authored-by: Martin Pokorny <[email protected]> Co-authored-by: Weiqun Zhang <[email protected]> Co-authored-by: Massimiliano Culpo <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates package simgrid: