Skip to content

spack diff any specs you want#32737

Merged
scheibelp merged 3 commits intospack:developfrom
scheibelp:features/diff-arbitrary-specs
Oct 11, 2022
Merged

spack diff any specs you want#32737
scheibelp merged 3 commits intospack:developfrom
scheibelp:features/diff-arbitrary-specs

Conversation

@scheibelp
Copy link
Copy Markdown
Member

@scheibelp scheibelp commented Sep 21, 2022

Fixes #31782

With this change, if a spec is concrete after parsing (e.g. spec.yaml or /hash-based), then it is not disambiguated (a process which requires (a) that the spec be installed and (b) that it be part of the currently active environment).

This means that you can:

  • Diff specs from an environment regardless of whether they have been installed (more useful for projection/matrix-based envs)
  • Diff specs read from .yaml files which may or may not be entirely different installations

@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality labels Sep 21, 2022
@alalazo alalazo self-assigned this Sep 21, 2022
Co-authored-by: Massimiliano Culpo <[email protected]>
@scheibelp
Copy link
Copy Markdown
Member Author

This is running into unrelated CI errors described by #32470

@scheibelp
Copy link
Copy Markdown
Member Author

Close/reopen to restart unit tests

@scheibelp
Copy link
Copy Markdown
Member Author

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Oct 10, 2022

I've started that pipeline for you!

@scheibelp scheibelp merged commit b594c0a into spack:develop Oct 11, 2022
luke-dt pushed a commit to dantaslab/spack that referenced this pull request Oct 12, 2022
Resolves spack#31782

With this change, if a spec is concrete after parsing (e.g. spec.yaml
or /hash-based), then it is not disambiguated (a process which requires
(a) that the spec be installed and (b) that it be part of the
currently-active environment).

This commit allows you to:

* Diff specs from an environment regardless of whether they have
  been installed (more useful for projection/matrix-based envs)
* Diff specs read from .yaml files which may or may not be entirely
  different installations of Spack

Co-authored-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands core PR affects Spack core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to diff specs from files

3 participants