FEniCSx: Updates for 0.5.1 by jhale · Pull Request #32665 · spack/spack

jhale · 2022-09-15T15:07:39Z

This (in my view!) supersedes #32611

Main differences:

I have opted to deprecated some older versions. As FEniCSx is currently in a development phase there is little use keeping the old versions around with the additional complexity required in the Spack files.
I have added the patch releases of Basix and DOLFINx.
Looking forward to changes on main I have bumped cmake to 3.19:. DOLFINx also does not require xtensor from now on.
Basix also requires C++20.

This is a draft pending successful CI run on our repository.

tldahlgren · 2022-09-15T17:11:33Z

This (in my view!) supersedes #32611

Oops. I merged that without looking at this PR first.

…release-0.5.0

Might be good to point out in our README how to fix Python version?

jhale · 2022-09-19T08:18:09Z

Please hold off on merging this until we've unmarked it as draft, there are a number of issues we'd like to fix.

jhale · 2022-09-29T07:15:21Z

@chrisrichardson @garth-wells Could one of you give this an approval for an automatic merge?

var/spack/repos/builtin/packages/fenics-dolfinx/package.py

tldahlgren

All but 3 new sha256 are confirmed. The others are provided in suggestions.

var/spack/repos/builtin/packages/fenics-dolfinx/package.py

var/spack/repos/builtin/packages/py-fenics-dolfinx/package.py

var/spack/repos/builtin/packages/py-fenics-ffcx/package.py

tldahlgren · 2022-09-29T20:11:08Z

@spackbot run pipeline

spackbot-app · 2022-09-29T20:11:12Z

I've started that pipeline for you!

Co-authored-by: Tamara Dahlgren <[email protected]>

jhale · 2022-09-30T09:45:01Z

All but 3 new sha256 are confirmed. The others are provided in suggestions.

Thanks for this detailed review work @tldahlgren, much appreciated.

…lease-0.5.0

tldahlgren

Confirmed all (19) new sha256.

tldahlgren · 2022-10-03T19:01:33Z

@chrisrichardson @garth-wells Did you want to take another look before this PR is merged?

chrisrichardson · 2022-10-03T19:46:18Z

Looks good

* Updates for DOLFINx 0.5.1 and associated packages * xtensor needed on anything less than main * Switch back to Python 3.7 minimum. * Might be good to point out in our README how to fix Python version? * Fix basix, xtensor dep * Add numba feature * Fix checksum * Make slepc optional Co-authored-by: Tamara Dahlgren <[email protected]>

…(py-dendropy, py-phylophlan, py-pkgconfig) (#32936) * added metaphlan v4, cleaned up phylophlan * added iqtree2 * fixed phylophlan, builds now * changed config.yaml to default * fixed style * py-jsonschema: add 4.16.0 and new package py-hatch-fancy-pypi-readme (#32929) * acfl: add v22.1 (#32915) Co-authored-by: Annop Wongwathanarat <[email protected]> * Fixup errors introduced by Clingo Pr: (#32905) * re2c depends on cmake on Windows * Winbison properly added to bootstrap package search list * Set CMAKE_HIP_ARCHITECTURES with the value of amdgpu_target (#32901) * libtiff: default to +zlib+jpeg (#32945) * octave: add version 7.2.0 (#32943) * simgrid new releases (#32920) * [rocksdb] Added rtti variant (#32918) * rvs binary path updated for 5.2 rocm release (#32892) * Add checksum for py-pytest-runner 6.0.0 (#32957) * py-einops: add v0.5.0 (#32959) * Replace repo with the NVIDIA one (#32951) * Add checksum for py-tomli 2.0.1 (#32949) * QMCPACK: add @3.15.0 (#32931) * Tidied up configure arguments to use special spack autotools features. (#32930) * casper: old domain fell off, adding github repo (#32928) * unifyfs: pin mercury version; add boost variant (#32911) Mercury has a new version (v2.2) releasing soon that UnifyFS does not build with and hasn't been tested with. This pins UnifyFS to the last version of Mercury used/tested. Add a variant to avoid building/using boost Append -std=gnu99 to cflags if building with gcc@4. Needed for mochi-margo to compile * trilinos: constrain superlu-dist version (#32889) * trilinos: constrain superlu-dist version for 13.x * syntax * FEniCSx: Updates for 0.5.1 (#32665) * Updates for DOLFINx 0.5.1 and associated packages * xtensor needed on anything less than main * Switch back to Python 3.7 minimum. * Might be good to point out in our README how to fix Python version? * Fix basix, xtensor dep * Add numba feature * Fix checksum * Make slepc optional Co-authored-by: Tamara Dahlgren <[email protected]> * simgrid: add variant and remove flag (#32797) * simgrid: remove std c++11 flag * simgrid: add msg variant * Axom: bring in changes from axom repo (#32643) * bring in changes from axom repo Co-authored-by: white238 <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]> * Add checksum for py-pyparsing 3.0.9 (#32952) * rdma-core: fix syntax for external discoverability (#32962) * Add checksum for py-flatbuffers 2.0.7 (#32955) * amrex: add v22.10 (#32966) * Remove CMakePackage.define alias from most packages (#32950) * Bug fix for `ca-certificates-mozilla/package.py` to enable `spack install --source` (#32953) * made suggested changes to iqtree2, py-dendropy, py-metaphlan, and py-pkgconfig. Poetry install still broken * reverted py-pkgconfig deps to poetry-core * made iqtree2 less dedundant, changes to py-dendropy and py-pkgconfig deps Co-authored-by: Manuela Kuhn <[email protected]> Co-authored-by: Annop Wongwathanarat <[email protected]> Co-authored-by: Annop Wongwathanarat <[email protected]> Co-authored-by: John W. Parent <[email protected]> Co-authored-by: Auriane R <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]> Co-authored-by: Kai Torben Ohlhus <[email protected]> Co-authored-by: Vinícius <[email protected]> Co-authored-by: Matthieu Dorier <[email protected]> Co-authored-by: renjithravindrankannath <[email protected]> Co-authored-by: iarspider <[email protected]> Co-authored-by: Paul R. C. Kent <[email protected]> Co-authored-by: Brian Van Essen <[email protected]> Co-authored-by: snehring <[email protected]> Co-authored-by: Cameron Stanavige <[email protected]> Co-authored-by: Cody Balos <[email protected]> Co-authored-by: Jack S. Hale <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]> Co-authored-by: Lucas Nesi <[email protected]> Co-authored-by: Chris White <[email protected]> Co-authored-by: white238 <[email protected]> Co-authored-by: Martin Pokorny <[email protected]> Co-authored-by: Weiqun Zhang <[email protected]> Co-authored-by: Massimiliano Culpo <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]>

jhale added 5 commits September 15, 2022 16:17

Updates for DOLFINx 0.5.1 and associated packages

4203cf6

xtensor needed on anything less than main

fbe9451

Fix

dcaf4a0

Fix

6ee6118

Fix deprecation

a20f7e2

spackbot-app bot added conflicts dependencies maintainers new-version python update-package labels Sep 15, 2022

spackbot-app bot requested review from chrisrichardson, garth-wells, mscroggs and nate-sime September 15, 2022 15:07

jhale marked this pull request as draft September 16, 2022 06:24

jhale added 4 commits September 16, 2022 08:47

Merge remote-tracking branch 'upstream/develop' into updates/fenicsx-…

7694f07

…release-0.5.0

black formatting

731d539

Merge remote-tracking branch 'upstream/develop' into updates/fenicsx-…

9139868

…release-0.5.0

Switch back to Python 3.7 minimum.

f658534

Might be good to point out in our README how to fix Python version?

chrisrichardson previously approved these changes Sep 17, 2022

View reviewed changes

Fix basix dep

44c7d75

jhale dismissed chrisrichardson’s stale review via 44c7d75 September 19, 2022 13:50

jhale added 4 commits September 19, 2022 16:05

Merge branch 'develop' into updates/fenicsx-release-0.5.0

98a1c4c

Fix xtensor deps.

03aaacd

Few extra tweaks

8d35201

Add numba feature

a2ea5da

spackbot-app bot added the new-variant label Sep 20, 2022

jhale marked this pull request as ready for review September 22, 2022 07:39

jhale added 2 commits September 22, 2022 10:08

Fix

86fdd26

Merge branch 'develop' into updates/fenicsx-release-0.5.0

252ebf5

chrisrichardson reviewed Sep 29, 2022

View reviewed changes

var/spack/repos/builtin/packages/fenics-dolfinx/package.py Outdated Show resolved Hide resolved

tldahlgren requested changes Sep 29, 2022

View reviewed changes

var/spack/repos/builtin/packages/fenics-dolfinx/package.py Outdated Show resolved Hide resolved

var/spack/repos/builtin/packages/py-fenics-dolfinx/package.py Outdated Show resolved Hide resolved

var/spack/repos/builtin/packages/py-fenics-ffcx/package.py Outdated Show resolved Hide resolved

tldahlgren self-assigned this Sep 29, 2022

jhale and others added 3 commits September 30, 2022 11:00

Fix checksum

ed4778f

Co-authored-by: Tamara Dahlgren <[email protected]>

Fix checksum

7294ee0

Co-authored-by: Tamara Dahlgren <[email protected]>

Fix checksum

d0a1b9a

Co-authored-by: Tamara Dahlgren <[email protected]>

chrisrichardson self-requested a review September 30, 2022 12:13

chrisrichardson previously approved these changes Sep 30, 2022

View reviewed changes

garth-wells previously approved these changes Sep 30, 2022

View reviewed changes

jhale added 2 commits October 3, 2022 14:43

Merge remote-tracking branch 'origin/develop' into updates/fenicsx-re…

963895d

…lease-0.5.0

Make slepc optional

64387f9

jhale dismissed stale reviews from garth-wells and chrisrichardson via 64387f9 October 3, 2022 12:46

jhale requested review from tldahlgren and removed request for mscroggs and nate-sime October 3, 2022 13:09

tldahlgren approved these changes Oct 3, 2022

View reviewed changes

tldahlgren merged commit 241b462 into spack:develop Oct 3, 2022

garth-wells deleted the updates/fenicsx-release-0.5.0 branch December 24, 2023 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FEniCSx: Updates for 0.5.1#32665

FEniCSx: Updates for 0.5.1#32665
tldahlgren merged 29 commits intospack:developfrom
FEniCS:updates/fenicsx-release-0.5.0

jhale commented Sep 15, 2022 •

edited

Loading

Uh oh!

tldahlgren commented Sep 15, 2022

Uh oh!

jhale commented Sep 19, 2022

Uh oh!

jhale commented Sep 29, 2022

Uh oh!

Uh oh!

tldahlgren left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tldahlgren commented Sep 29, 2022

Uh oh!

spackbot-app bot commented Sep 29, 2022

Uh oh!

jhale commented Sep 30, 2022

Uh oh!

tldahlgren left a comment

Uh oh!

tldahlgren commented Oct 3, 2022

Uh oh!

chrisrichardson commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jhale commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tldahlgren commented Sep 15, 2022

Uh oh!

jhale commented Sep 19, 2022

Uh oh!

jhale commented Sep 29, 2022

Uh oh!

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tldahlgren commented Sep 29, 2022

Uh oh!

spackbot-app bot commented Sep 29, 2022

Uh oh!

jhale commented Sep 30, 2022

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

tldahlgren commented Oct 3, 2022

Uh oh!

chrisrichardson commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jhale commented Sep 15, 2022 •

edited

Loading