Fenicsx v0.5.0#32611
Merged
tldahlgren merged 17 commits intospack:developfrom Sep 15, 2022
FEniCS:fenicsx_v0.5.0
Merged
Conversation
spackbot-app
bot
requested review from
chrisrichardson,
garth-wells,
mscroggs and
nate-sime
nate-sime
previously approved these changes
Sep 12, 2022
garth-wells
suggested changes
Sep 12, 2022
Contributor
garth-wells
left a comment
garth-wells
left a comment
There was a problem hiding this comment.
Looks good, I've left some inline comments.
(py)-fenics-dolfinx@main no longer depends on xtl and xtensor.
Has this PR been tested using the CI at https://github.com/FEniCS/dolfinx/actions/workflows/spack.yml?
ma595
requested review from
garth-wells
and removed request for
chrisrichardson and
mscroggs
The 0.5.1 release removes the C++ build dependency on Python that sneaked into the 0.5.0 build system.
garth-wells
approved these changes
Sep 14, 2022
chrisrichardson
approved these changes
Sep 14, 2022
nate-sime
approved these changes
Sep 14, 2022
Contributor
|
@tldahlgren I think this is ready to merge now. |
Contributor
|
I have a slightly refined version of this patch that better reflects some upcoming changes on |
tldahlgren
approved these changes
Sep 15, 2022
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed all new sha256.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update fenicsx packages to latest tagged releases (v0.5.0).