CMakePackage: allow custom CMAKE_PREFIX_PATH entries#32547
Merged
becker33 merged 6 commits intospack:developfrom Sep 8, 2022
Merged
CMakePackage: allow custom CMAKE_PREFIX_PATH entries#32547becker33 merged 6 commits intospack:developfrom
becker33 merged 6 commits intospack:developfrom
Conversation
…to the CMAKE_PREFIX_PATH option of the cmake invocation (via CMakePackage)
spackbot-app
bot
added
build-environment
core
This comment was marked as off-topic.
This comment was marked as off-topic.
becker33
requested changes
Sep 8, 2022
Member
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
I think providing a default method on PackageBase will make this simpler.
spackbot-app
bot
added
dependencies
new-version
tests
Member
Author
|
@becker33 I have made the requested changes and added a test |
becker33
approved these changes
Sep 8, 2022
Contributor
|
@scheibelp and @becker33 thank you both for helping this get merged! |
ma595
pushed a commit
to ma595/spack
that referenced
this pull request
Sep 13, 2022
* define `cmake_prefix_paths` property for packages add to CMake arguments via CMakePackage Co-authored-by: Robert Underwood <[email protected]>
robertu94
added a commit
to robertu94/spack
that referenced
this pull request
Oct 12, 2022
+ new package versions + found a dependency `dlib` that didn't correspond to the same `dlib` that libpressio-opt refers to. Renamed the old package because it had way fewer users, and davisking/dlib hold the dlib name in Ubuntu, Fedora, Homebrew, Pip. Discused with @adamjstewart who added the old dlib package, and he was okay with the replacement + added missing fix for CUB relating to spack#32547 needed for cuSZ to build using Spack.
robertu94
added a commit
to robertu94/spack
that referenced
this pull request
Oct 12, 2022
+ new package versions + found a dependency `dlib` that didn't correspond to the same `dlib` that libpressio-opt refers to. Renamed the old package because it had way fewer users, and davisking/dlib hold the dlib name in Ubuntu, Fedora, Homebrew, Pip. Discused with @adamjstewart who added the old dlib package, and he was okay with the replacement + added missing fix for CUB relating to spack#32547 needed for cuSZ to build using Spack.
robertu94
added a commit
to robertu94/spack
that referenced
this pull request
Oct 12, 2022
+ new package versions + found a dependency `dlib` that didn't correspond to the same `dlib` that libpressio-opt refers to. Renamed the old package because it had way fewer users, and davisking/dlib hold the dlib name in Ubuntu, Fedora, Homebrew, Pip. Discused with @adamjstewart who added the old dlib package, and he was okay with the replacement + added missing fix for CUB relating to spack#32547 needed for cuSZ to build using Spack.
robertu94
added a commit
to robertu94/spack
that referenced
this pull request
Oct 12, 2022
+ new package versions + found a dependency `dlib` that didn't correspond to the same `dlib` that libpressio-opt refers to. Renamed the old package because it had way fewer users, and davisking/dlib hold the dlib name in Ubuntu, Fedora, Homebrew, Pip. Discused with @adamjstewart who added the old dlib package, and he was okay with the replacement + added missing fix for CUB relating to spack#32547 needed for cuSZ to build using Spack.
robertu94
added a commit
to robertu94/spack
that referenced
this pull request
Oct 12, 2022
+ new package versions + found a dependency `dlib` that didn't correspond to the same `dlib` that libpressio-opt refers to. Renamed the old package because it had way fewer users, and davisking/dlib hold the dlib name in Ubuntu, Fedora, Homebrew, Pip. Discused with @adamjstewart who added the old dlib package, and he was okay with the replacement + added missing fix for CUB relating to spack#32547 needed for cuSZ to build using Spack.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31631
Users can update the CMAKE_PREFIX_PATH environment variable in
setup_dependent_build_environment. However, CMakePackage passes a CMAKE_PREFIX_PATH option tocmakethat does not account for these changes; the option overrides the environment variable.#31631 reorganizes the code to make use of this, but reuses functions that are not necessarily idempotent.
This PR allows a package to define a
cmake_search_pathsattribute, which is then included in the CMAKE_PREFIX_PATH option to cmake.Note: this PR also retains the existing modifications to the CMAKE_PREFIX_PATH environment variable in
build_environment.pybecause not all CMake-dependent packages inherit fromCMakePackage.