Merged
Conversation
ax3l
commented
Sep 1, 2022
adamjstewart
reviewed
Sep 1, 2022
ax3l
force-pushed
the
add-sphinx-design
branch
from
2afcfb9 to
f5d5506
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Needed for spack#32480
ax3l
force-pushed
the
add-sphinx-design
branch
from
f5d5506 to
a200f9c
Compare
Member
Author
|
@spackbot fix style |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, mypy, black, flake8
==> Modified files
var/spack/repos/builtin/packages/py-sphinx-design/package.py
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 558 source files
mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-sphinx-design/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
I've updated the branch with isort fixes. |
|
Let me see if I can fix that for you! |
adamjstewart
approved these changes
Sep 1, 2022
Member
@scottwittenburg this should say "black fixes", not "isort fixes". |
ma595
pushed a commit
to ma595/spack
that referenced
this pull request
Sep 13, 2022
* Add: py-sphinx-design Needed for spack#32480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #32480