Features/tensorflow by tgamblin · Pull Request #3244 · spack/spack

tgamblin · 2017-02-26T18:10:52Z

This is work in progress. It leverages the contributed CMake build of TensorFlow to build without Basel. The build Tricks CMake into thinking that the external projects are already installed.

All dependencies currently build successfully. Currently fighting with the Eigen headers in the final TensorFlow build.

dependency builds
Tensorflow build
GPU support

- Bugfixes for spack find - 0.9.1 can read specs from current develop.

- added new version of eigen - make jpeg install build headers for tensorflow

davydden · 2017-02-26T18:12:56Z

var/spack/repos/builtin/packages/eigen/package.py


+    #version('290bfb42684a', url='http://bitbucket.org/eigen/eigen/get/290bfb42684a.tar.gz',
+    #        sha256='269c8bf20e8ac1aa8f5caf1ab2ca7be4909ec6ae085177a647aae138cd069b12')
+    version('290bfb42684a', url='http://bitbucket.org/eigen/eigen/get/290bfb42684a.tar.gz',


i think this could be 2.9.0.bfb42684a. The first three numbers don't look random to me.

That's part of the sha256. Definitely random.

davydden · 2017-02-26T18:13:52Z

var/spack/repos/builtin/packages/tensorflow/package.py

+
+    homepage = "https://www.tensorflow.org/"
+
+    version('e697cf7', git='https://github.com/tensorflow/tensorflow.git', commit='e697cf787b09193a6921af6d2b7db2d6c4d2a5dd')


put commit on the new line?

adamjstewart · 2017-02-26T19:04:42Z

var/spack/repos/builtin/packages/jpeg/package.py

    homepage = "http://www.ijg.org"
-    url      = "http://www.ijg.org/files/jpegsrc.v9b.tar.gz"
+    url      = "http://www.ijg.org/files/jpegsrc.v8b.tar.gz"



Can you undo this URL change?

davydden · 2017-02-26T19:07:51Z

var/spack/repos/builtin/packages/tensorflow/package.py

+
+    version('e697cf7', git='https://github.com/tensorflow/tensorflow.git', commit='e697cf787b09193a6921af6d2b7db2d6c4d2a5dd')
+
+    depends_on('[email protected]')


is it so strict?

jcftang · 2017-04-01T07:20:52Z

Rather than pushing directly into this feature branch, I've stashed some changes that I made on my own repo at https://github.com/jcftang/spack/commits/features/tensorflow.

The latest versions of tensorflow includes tensorboard which also pulls in a number of external javascript dependencies. The branch I have is still not in a usable state.

adamjstewart · 2017-04-25T12:36:21Z

I was looking more into Bazel today. I thought we had rejected Bazel because it fetched its own dependencies and we didn't want that. Looking at the documentation, it isn't hard to suppress that:
https://bazel.build/versions/master/docs/bazel-user-manual.html#fetch
Maybe we should just add a BazelPackage base class that does this?

eschnett · 2017-04-26T20:58:12Z

I'm interested in installing TensorFlow via Spack. Could you describe the status of this pull request -- is it (1) basically working, but needs to be cleaned up, or (2) work-in-progress, and I should rather install TensorFlow from sources?

alalazo · 2017-05-07T17:41:36Z

I was looking more into Bazel today. I thought we had rejected Bazel because it fetched its own dependencies and we didn't want that. Looking at the documentation, it isn't hard to suppress that:
https://bazel.build/versions/master/docs/bazel-user-manual.html#fetch Maybe we should just add a BazelPackage base class that does this?

@adamjstewart I think we have two competing PRs for Tensorflow: #2043 seems Bazel based, this one CMake based.

ifelsefi · 2017-05-24T16:24:06Z

Any update on this PR? Quite a few users here are installing Tensorflow themselves so it would be great to have it in Spack.

I think cmake would be the best way.

Any update on GPU support? I don't see depends_on("cuda") or depends_on("cudnn") which are in Spack already and required for GPUs on Tensorflow.

ifelsefi · 2017-07-10T13:59:12Z

Any update?

ifelsefi · 2017-08-24T15:19:20Z

Can we get this added?

tgamblin · 2017-08-24T18:05:46Z

I'm not sure I'll have time to finish this in the next month or so. I'd like to get to it, though. I'm happy to try to help anyone who wants to keep pushing it.

junghans · 2017-10-27T17:57:50Z

@tgamblin: Can you hack that together soon?

alalazo · 2017-12-06T17:58:43Z

Here's a reference to Easybuild's recipe for tensorflow.

tgamblin · 2019-07-15T21:31:15Z

Closing this as the CMake build is no longer supported by the TF team.

alalazo and others added 22 commits May 18, 2016 08:28

fixes spack#967

6e1257e

Version bump to 0.9.1

164da8e

- Bugfixes for spack find - 0.9.1 can read specs from current develop.

Don't assume spack is in the path when building docs.

4f8167b

Merge branch 'releases/v0.10.0'

52a9e5d

Added gemmlowp package

9cbf6c0

Adding farmhash package from google

f50a51a

Removed trailing spaces

568b579

Adding highwayhash package from Google

d5dd176

Removed trailing white spaces and tab

8d38a56

new branch

807e212

added dependencies

9d9f420

formatting fixes

9085522

Edited homepage and git repo url

ebe388d

Added the highwayhash package for Tensorflow

91d0484

Fixed the numerous flake8 issues

dcf0dcf

mockup fake external project directories

ec098b5

Merge branch 'features/farmhash' into features/tensorflow

2aec1f4

Merge branch 'features/gemmlowp' into features/tensorflow

61a60e2

Merge branch 'features/gemmlowp' into features/tensorflow

607c8a8

Merge branch 'features/highwayhash' into features/tensorflow

5e8b93a

Fixed versions of tensorflow dependencies

dd1e8c8

- added new version of eigen - make jpeg install build headers for tensorflow

edited for versioning

296a0c1

tgamblin added the WIP label Feb 26, 2017

davydden reviewed Feb 26, 2017

View reviewed changes

adamjstewart reviewed Feb 26, 2017

View reviewed changes

davydden reviewed Feb 26, 2017

View reviewed changes

adamjstewart added the new-package label Apr 9, 2017

alalazo mentioned this pull request May 7, 2017

Add package tensorflow [draft] #2043

Closed

junghans added 3 commits October 26, 2017 14:27

Merge remote-tracking branch 'origin/develop' into features/tensorflow

12a9bd5

highwayhash: version bump for gcc-7

6197057

tensorflow: some more fixes

5510687

alalazo added the help wanted label Nov 7, 2017

boegel mentioned this pull request Feb 8, 2018

Proposal: Making the cmake build distribution friendly tensorflow/tensorflow#13061

Closed

gijzelaerr mentioned this pull request Jun 20, 2018

make tensorflow package TRASAL/spack#7

Closed

tgamblin closed this Jul 15, 2019

adamjstewart mentioned this pull request Aug 14, 2019

What is the status of tensorflow on spack? #9352

Closed

dodo47 mentioned this pull request Nov 10, 2019

Add new TensorFlow package #13112

Merged


		homepage = "https://www.tensorflow.org/"

		version('e697cf7', git='https://github.com/tensorflow/tensorflow.git', commit='e697cf787b09193a6921af6d2b7db2d6c4d2a5dd')


		version('e697cf7', git='https://github.com/tensorflow/tensorflow.git', commit='e697cf787b09193a6921af6d2b7db2d6c4d2a5dd')

		depends_on('[email protected]')

Conversation

tgamblin commented Feb 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davydden Feb 26, 2017

Choose a reason for hiding this comment

Uh oh!

adamjstewart Apr 9, 2017

Choose a reason for hiding this comment

Uh oh!

davydden Feb 26, 2017

Choose a reason for hiding this comment

Uh oh!

adamjstewart Feb 26, 2017

Choose a reason for hiding this comment

Uh oh!

davydden Feb 26, 2017

Choose a reason for hiding this comment

Uh oh!

jcftang commented Apr 1, 2017

Uh oh!

adamjstewart commented Apr 25, 2017

Uh oh!

eschnett commented Apr 26, 2017

Uh oh!

alalazo commented May 7, 2017

Uh oh!

ifelsefi commented May 24, 2017

Uh oh!

ifelsefi commented Jul 10, 2017

Uh oh!

ifelsefi commented Aug 24, 2017

Uh oh!

tgamblin commented Aug 24, 2017

Uh oh!

junghans commented Oct 27, 2017

Uh oh!

alalazo commented Dec 6, 2017

Uh oh!

tgamblin commented Jul 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tgamblin commented Feb 26, 2017 •

edited

Loading