llvm: fix 15.0.0rc builds on MacOS with command-line-tools#32397
Merged
tldahlgren merged 2 commits intodevelopfrom Aug 31, 2022
Merged
llvm: fix 15.0.0rc builds on MacOS with command-line-tools#32397tldahlgren merged 2 commits intodevelopfrom
tldahlgren merged 2 commits intodevelopfrom
Conversation
Ref: llvm/llvm-project#57037 i.e use -DBUILTINS_CMAKE_ARGS=-DCOMPILER_RT_ENABLE_IOS=OFF. But this needs switching "compiler-rt" from "projects" to "runtimes". Also fixing the warnings below fixes compile errors CMake Warning at CMakeLists.txt:101 (message): Using LLVM_ENABLE_PROJECTS=libcxx is deprecated now, please use -DLLVM_ENABLE_RUNTIMES=libcxx or see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes. CMake Warning at CMakeLists.txt:101 (message): Using LLVM_ENABLE_PROJECTS=libcxxabi is deprecated now, please use -DLLVM_ENABLE_RUNTIMES=libcxxabi or see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes. CMake Warning at CMakeLists.txt:101 (message): Using LLVM_ENABLE_PROJECTS=libunwind is deprecated now, please use -DLLVM_ENABLE_RUNTIMES=libunwind or see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes. /private/var/folders/nt/_m1t_x7j76q6sl3xt91tqgs00000gn/T/balay/spack-stage/spack-stage-llvm-15.0.0-rc2-h2t5bohzyy7exz2ub3m42pfycjcmbndk/spack-build-h2t5boh/include/c++/v1/cstdlib:135:9: error: no member named 'at_quick_exit' in the global namespace using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; ~~^
tldahlgren
previously approved these changes
Aug 27, 2022
Contributor
Co-authored-by: Tamara Dahlgren <[email protected]>
ma595
pushed a commit
to ma595/spack
that referenced
this pull request
Sep 13, 2022
* llvm: fix 15.0.0rc builds on MacOS with command-line-tools Ref: llvm/llvm-project#57037 i.e use -DBUILTINS_CMAKE_ARGS=-DCOMPILER_RT_ENABLE_IOS=OFF. But this needs switching "compiler-rt" from "projects" to "runtimes". Also fixing the warnings below fixes compile errors CMake Warning at CMakeLists.txt:101 (message): Using LLVM_ENABLE_PROJECTS=libcxx is deprecated now, please use -DLLVM_ENABLE_RUNTIMES=libcxx or see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes. CMake Warning at CMakeLists.txt:101 (message): Using LLVM_ENABLE_PROJECTS=libcxxabi is deprecated now, please use -DLLVM_ENABLE_RUNTIMES=libcxxabi or see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes. CMake Warning at CMakeLists.txt:101 (message): Using LLVM_ENABLE_PROJECTS=libunwind is deprecated now, please use -DLLVM_ENABLE_RUNTIMES=libunwind or see the instructions at https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes. /private/var/folders/nt/_m1t_x7j76q6sl3xt91tqgs00000gn/T/balay/spack-stage/spack-stage-llvm-15.0.0-rc2-h2t5bohzyy7exz2ub3m42pfycjcmbndk/spack-build-h2t5boh/include/c++/v1/cstdlib:135:9: error: no member named 'at_quick_exit' in the global namespace using ::at_quick_exit _LIBCPP_USING_IF_EXISTS; ~~^ * Update var/spack/repos/builtin/packages/llvm/package.py Co-authored-by: Tamara Dahlgren <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: llvm/llvm-project#57037
i.e use -DBUILTINS_CMAKE_ARGS=-DCOMPILER_RT_ENABLE_IOS=OFF. But this needs switching "compiler-rt" from "projects" to "runtimes".
Also fixing the warnings below fixes compile errors
CMake Warning at CMakeLists.txt:101 (message):
Using LLVM_ENABLE_PROJECTS=libcxx is deprecated now, please use
-DLLVM_ENABLE_RUNTIMES=libcxx or see the instructions at
https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes.
CMake Warning at CMakeLists.txt:101 (message):
Using LLVM_ENABLE_PROJECTS=libcxxabi is deprecated now, please use
-DLLVM_ENABLE_RUNTIMES=libcxxabi or see the instructions at
https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes.
CMake Warning at CMakeLists.txt:101 (message):
Using LLVM_ENABLE_PROJECTS=libunwind is deprecated now, please use
-DLLVM_ENABLE_RUNTIMES=libunwind or see the instructions at
https://libcxx.llvm.org/BuildingLibcxx.html for building the runtimes.
/private/var/folders/nt/_m1t_x7j76q6sl3xt91tqgs00000gn/T/balay/spack-stage/spack-stage-llvm-15.0.0-rc2-h2t5bohzyy7exz2ub3m42pfycjcmbndk/spack-build-h2t5boh/include/c++/v1/cstdlib:135:9: error: no member named 'at_quick_exit' in the global namespace
using ::at_quick_exit _LIBCPP_USING_IF_EXISTS;
~~^
Also ref: #31945
cc: @William-Mou