Allow requirements for virtual packages#32369
Merged
scheibelp merged 4 commits intospack:developfrom Aug 26, 2022
Merged
Conversation
spackbot-app
bot
added
core
Extend the semantic of package requirements to allow using them also under a virtual package attribute in packages.yaml These requirements are enforced whenever that virtual spec is present in the DAG.
alalazo
force-pushed
the
features/extend_requirements_to_virtual
branch
from
91071a0 to
8ef145e
Compare
scheibelp
requested changes
Aug 25, 2022
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
I have a few questions and a couple of minor comments about docs/renaming.
Member
Author
|
@scheibelp Ready for a second review |
scheibelp
approved these changes
Aug 26, 2022
Member
|
Thanks! |
ma595
pushed a commit
to ma595/spack
that referenced
this pull request
Sep 13, 2022
Extend the semantics of package requirements to allow using them also under a virtual package attribute in packages.yaml These requirements are enforced whenever that virtual spec is present in the DAG.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the semantic of package requirements to allow using them also under a virtual package attribute in
packages.yaml. These requirements are enforced whenever that virtual spec is present in the DAG.Modifications: