Probably worth merging all E4S CI PRs into a single PR. Btw, doc tests are broken on develop, so you'll need to rebase all PRs after those are fixed.

Probably worth merging all E4S CI PRs into a single PR. Btw, doc tests are broken on develop, so you'll need to rebase all PRs after those are fixed.

FWIW. If there's a chance that any of these fail I think there's value in having them in separate PRs in the sense that it is a way to allow maintainers to know that it is their package that has issues in the stack, at least when it is first added.

Def makes it simpler to debug, although it's going to be fun to resolve merge constraints in all PRs since they all touch the same file. Also creates a lot of redundant CI runs...

Probably worth merging all E4S CI PRs into a single PR. Btw, doc tests are broken on develop, so you'll need to rebase all PRs after those are fixed.

FWIW. If there's a chance that any of these fail I think there's value in having them in separate PRs in the sense that it is a way to allow maintainers to know that it is their package that has issues in the stack, at least when it is first added.

This was my thought. I'd rather have them all in one, but having them individually will leave a record of the failures that we can reference with maintainers and other stakeholders while allowing us to merge others.

Also creates a lot of redundant CI runs...

Are you talking about the GitLab pipeline builds? Why would it create redundant runs? It should only build the affected package, in this case the package being uncommented.

Looks like the package fails to build. See https://gitlab.spack.io/spack/spack/-/jobs/3028886.

Looks like the package fails to build. See https://gitlab.spack.io/spack/spack/-/jobs/3028886.

...
     191    In file included from device_utils.c:10:
  >> 192    ./_hypre_utilities.hpp:116:10: fatal error: 'rocsparse.h' file not 
            found
     193    #include <rocsparse.h>
     194             ^~~~~~~~~~~~~
     195    1 error generated when compiling for gfx90a.
...

Issue created here:

• [email protected] +rocm fails: _hypre_utilities.hpp:116:10: fatal error: 'rocsparse.h' file not found #32194

Rebased on develop following resolution of #32194 (comment) via merge of PR #33073 (comment)

@spackbot run pipeline

I've started that pipeline for you!