Skip to content

info: properly report default when for overridden variants#32040

Merged
alalazo merged 1 commit intospack:developfrom
tldahlgren:bugfix/info-when-override-fix
Aug 11, 2022
Merged

info: properly report default when for overridden variants#32040
alalazo merged 1 commit intospack:developfrom
tldahlgren:bugfix/info-when-override-fix

Conversation

@tldahlgren
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren commented Aug 10, 2022

Fixes #31671

This PR properly reports default when for overridden variants when using the spack info command.

Before:

Variants:
    Name [Default]          When    Allowed values          Description
    ====================    ====    ====================    ==================================

    build_type [Release]    [, ]    Debug, Release,         CMake build type
                                    RelWithDebInfo,         
                                    MinSizeRel              
    ipo [off]               --      on, off                 CMake interprocedural optimization

After:

Variants:
    Name [Default]          When    Allowed values          Description
    ====================    ====    ====================    ==================================

    build_type [Release]    --      Debug, Release,         CMake build type
                                    RelWithDebInfo,         
                                    MinSizeRel              
    ipo [off]               --      on, off                 CMake interprocedural optimization

@tldahlgren tldahlgren requested review from alalazo and becker33 August 10, 2022 21:05
@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality labels Aug 10, 2022
@tldahlgren tldahlgren added the bugfix Something wasn't working, here's a fix label Aug 10, 2022
@tldahlgren
Copy link
Copy Markdown
Contributor Author

tldahlgren commented Aug 10, 2022

@jrmadsen Can you test to see if this resolves your problem?

@alalazo alalazo merged commit f96b54b into spack:develop Aug 11, 2022
@alalazo alalazo mentioned this pull request Aug 11, 2022
Closed
12 tasks
@greenc-FNAL greenc-FNAL mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@becker33 becker33 Awaiting requested review from becker33

Assignees

No one assigned

Labels

bugfix Something wasn't working, here's a fix commands core PR affects Spack core functionality

Projects

No open projects
Spack v0.18.2 release
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicating variant in package to change default results in incorrect When field

2 participants

@tldahlgren @alalazo