gitlab ci: Fix broken SPACK_CHECKOUT_VERSION#31963
Closed
scottwittenburg wants to merge 1 commit intospack:developfrom
Closed
gitlab ci: Fix broken SPACK_CHECKOUT_VERSION#31963scottwittenburg wants to merge 1 commit intospack:developfrom
scottwittenburg wants to merge 1 commit intospack:developfrom
Conversation
spackbot-app
bot
added
commands
core
Contributor
Author
Contributor
|
This fixes #31952 unless the Spack instance is not a Git repository, in which case it's the bare Spack version (e.g. Would it be possible to move this Lines 134 to 149 in c5fb023 |
tldahlgren
reviewed
Aug 8, 2022
|
|
||
| with ev.read("test"): | ||
| monkeypatch.setattr(spack.main, "get_version", lambda: "0.15.3-416-12ad69eb1") | ||
| monkeypatch.setattr(spack.main, "get_version", lambda: "0.19.0.dev0 (blah)") |
Contributor
There was a problem hiding this comment.
Love the sha256 example. 😉
Member
|
@scottwittenburg should we close this PR now that #38778 is merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #31952
The generated
.gitlab-ci.ymlcontains a variableSPACK_CHECKOUT_VERSIONthat generated child jobs should be able to use to checkout the version of spack that generated the pipeline. Since the value returned byspack.main.get_version()looks like0.18.1.dev0 (<git-commit-sha>)these days, this PR updates the way the commit sha is extracted accordingly.