Skip to content

LLVM: add @15.0.0-rc1#31945

Merged
tldahlgren merged 1 commit intospack:developfrom
William-Mou:develop
Aug 17, 2022
Merged

LLVM: add @15.0.0-rc1#31945
tldahlgren merged 1 commit intospack:developfrom
William-Mou:develop

Conversation

@William-Mou
Copy link
Copy Markdown
Contributor

Add [email protected]
It's an important version for the M1 mac.
Clang 15 ([email protected]) started to support -march=native for Apple M1.

ref: why-does-march-native-not-work-on-apple-m1

@trws
Copy link
Copy Markdown
Contributor

trws commented Aug 5, 2022

Builds for me on an M1 mac, but this probably shouldn't be preferred since it's a pre-release version.

tldahlgren
tldahlgren previously approved these changes Aug 8, 2022
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the sha256

@tldahlgren
Copy link
Copy Markdown
Contributor

Will defer merge decision to give maintainers a chance to comment.

@tldahlgren tldahlgren self-assigned this Aug 8, 2022
@trws
Copy link
Copy Markdown
Contributor

trws commented Aug 8, 2022

@William-Mou, I'm good with adding this verison, but as it is it would become the default version of llvm built for spack install llvm, would you add preferred=True to the last stable version below this so we can avoid that?

@William-Mou
Copy link
Copy Markdown
Contributor Author

Hi @trws, Thank you for your reminder!
I've added this flag to the last stable version.

@haampie
Copy link
Copy Markdown
Member

haampie commented Aug 9, 2022

Can we remove the rc version from Spack after LLVM 15 is released? Or will it stay around forever?

Notice that spack install [email protected] is possible too without this PR with the only downside that you don't get shasum verification on the sources.

@William-Mou
Copy link
Copy Markdown
Contributor Author

William-Mou commented Aug 9, 2022

Hi @haampie,
I'm not sure if this is the question posed to me, but it seems to me that we should remove this version when llvm 15.0.0 is released.
In my view, 15.0.0-rc1 appears as an option in spack, which can enhance the confidence of users.

@William-Mou William-Mou requested a review from tldahlgren August 15, 2022 09:27
@William-Mou
Copy link
Copy Markdown
Contributor Author

Hi,
It has been a while since I responded.
Should I close this PR?

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed new sha256 and note @trws 's request for 14.0.6 to be preferred has be added.

@tldahlgren tldahlgren enabled auto-merge (squash) August 17, 2022 22:37
@tldahlgren
Copy link
Copy Markdown
Contributor

Looks like CI pipeline has hung.

@tldahlgren
Copy link
Copy Markdown
Contributor

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Aug 17, 2022

I've started that pipeline for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants