kokkos: set CMAKE_CXX_STANDARD instead of Kokkos_CXX_STANDARD#31841
Merged
eugeneswalker merged 2 commits intodevelopfrom Aug 1, 2022
Merged
kokkos: set CMAKE_CXX_STANDARD instead of Kokkos_CXX_STANDARD#31841eugeneswalker merged 2 commits intodevelopfrom
eugeneswalker merged 2 commits intodevelopfrom
Conversation
dalg24
suggested changes
Aug 1, 2022
dalg24
left a comment
dalg24
left a comment
There was a problem hiding this comment.
Please use CMAKE_CXX_STANDARD unconditionally
dalg24
approved these changes
Aug 1, 2022
wspear
approved these changes
Aug 1, 2022
eugeneswalker
changed the title
crtrott
approved these changes
Aug 1, 2022
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
…31841) * kokkos@develop: set CMAKE_CXX_STANDARD instead of Kokkos_CXX_STANDARD * use CMAKE_CXX_STANDARD regardless of kokkos version
alalazo
pushed a commit
to alalazo/spack
that referenced
this pull request
Aug 17, 2022
…31841) * kokkos@develop: set CMAKE_CXX_STANDARD instead of Kokkos_CXX_STANDARD * use CMAKE_CXX_STANDARD regardless of kokkos version
haampie
pushed a commit
that referenced
this pull request
Aug 17, 2022
* kokkos@develop: set CMAKE_CXX_STANDARD instead of Kokkos_CXX_STANDARD * use CMAKE_CXX_STANDARD regardless of kokkos version
marcost2
pushed a commit
to marcost2/spack
that referenced
this pull request
Aug 26, 2022
…31841) * kokkos@develop: set CMAKE_CXX_STANDARD instead of Kokkos_CXX_STANDARD * use CMAKE_CXX_STANDARD regardless of kokkos version
ma595
pushed a commit
to ma595/spack
that referenced
this pull request
Sep 13, 2022
…31841) * kokkos@develop: set CMAKE_CXX_STANDARD instead of Kokkos_CXX_STANDARD * use CMAKE_CXX_STANDARD regardless of kokkos version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like CXX standard needs to be set differently for
kokkos@develop.Without this PR, you get this error when trying to build
kokkos@develop:@crtrott @janciesko @wspear