Python: fix clingo bootstrapping on Apple M1/M2#31792
Merged
alalazo merged 3 commits intospack:developfrom Aug 1, 2022
Merged
Conversation
spackbot-app
bot
requested review from
alalazo,
scheibelp,
skosukhin,
tgamblin and
varioustoxins
This was referenced Jul 28, 2022
adamjstewart
changed the title
Contributor
|
Works like a charm on M1 Max. It did build a somewhat depressing number of packages to get there, finding externals for cmake and python but for none of: perl, bison, m4, readline, diffutils, etc. but it built and worked like a charm, great stuff! |
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
adamjstewart
force-pushed
the
fixes/python
branch
from
32ac335 to
77ef175
Compare
adamjstewart
force-pushed
the
fixes/python
branch
from
77ef175 to
b2adc37
Compare
auto-merge was automatically disabled
August 1, 2022 14:40
Pull request was closed
alalazo
approved these changes
Aug 1, 2022
Contributor
|
Yay finally merged 😂 Thanks again @adamjstewart ! |
adamjstewart
added
macOS
bootstrap
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
marcost2
pushed a commit
to marcost2/spack
that referenced
this pull request
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30834 that solves one last issue with clingo bootstrapping when using the system Python that comes with Xcode. This is a more general solution than #31791 and should also help when using an external Python to install packages.
Fixes #31717
Fixes #31735
Closes #31791
@sethrj