Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

• lerc

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['adamjstewart']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame lerc

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

It works for me. Thanks.

@alalazo @adamjstewart I was having the same problem and pulled in spack develop as of a few days ago. I can see the commit in git log, but if I look at https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/lerc/package.py I don't see the actual change. Do you know what happened?

For now, I cherry-picked your commit 77537fa again on top of develop (b1e499d) that I pulled in on Aug 15, and now I can see the change in the lerc package.

It looks like it was removed in 08e75f7. There are also other new features that were accidentally reverted in that commit. @renjithravindrankannath @cgmb @srekolam I think what happened was that there was a bad rebase of #31591 that pulled in a bunch of changes from develop, then those changes were undone in multiple commits like 3bc3c80. So the PR branch shows no changes, but in reality that PR undoes those changes. @alalazo what's the best thing to do here? Revert 08e75f7 or manually re-add the removed features?

It looks like it was removed in 08e75f7. There are also other new features that were accidentally reverted in that commit. @renjithravindrankannath @cgmb @srekolam I think what happened was that there was a bad rebase of #31591 that pulled in a bunch of changes from develop, then those changes were undone in multiple commits like 3bc3c80. So the PR branch shows no changes, but in reality that PR undoes those changes. @alalazo what's the best thing to do here? Revert 08e75f7 or manually re-add the removed features?

Thanks, @adamjstewart for looking into this so quickly.

Honestly this feels like a security vulnerability in GitHub. Contributors shouldn't be able to remove commits from a project in a PR when the diff shows no visible changes. Going to report this to the folks at GitHub.

Apologies!! i think it was all okay when the initial PR #31591 was raised and addressed the review comments but later it was bad rebase that showed changes that was not intended to in that PR . So, it was taken out from that PR.

Sorry about that...!! The commit 08e75f7 was not intended and I reverted the unintended changes manually. But I think it was lost after a rebase and it didn't list in the list of changes before merge.