Skip to content

Add patch to allow ncurses to be built with PGI#3135

Merged
tgamblin merged 1 commit intospack:developfrom
adamjstewart:fixes/ncurses-pgi
Feb 17, 2017
Merged

Add patch to allow ncurses to be built with PGI#3135
tgamblin merged 1 commit intospack:developfrom
adamjstewart:fixes/ncurses-pgi

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

Without this patch, make crashes with:

PGC-S-0239-Unmatched #else (../ncurses/expanded.c: 61)
PGC-S-0240-Unmatched #endif (../ncurses/expanded.c: 63)
PGC/x86-64 Linux 16.5-0: compilation completed with severe errors
make[1]: *** [../obj_s/expanded.o] Error 2

This patch came from the developer, and should be included in the next release.

Even with this patch, the PGI build failed with dozens of lines like:

ld: ../obj_s/hardscroll.o: relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC

Adding CFLAGS=-fPIC and CXXFLAGS=-fPIC solved this problem.

Also converted to AutotoolsPackage while I was at it. Also locked down the previous patch to @6.0 only as it wouldn't apply to @5.9.

@tgamblin tgamblin merged commit 4f60011 into spack:develop Feb 17, 2017
@adamjstewart adamjstewart deleted the fixes/ncurses-pgi branch February 18, 2017 22:43
diaena pushed a commit to diaena/spack that referenced this pull request May 26, 2017
xavierandrade pushed a commit to xavierandrade/spack that referenced this pull request Jun 16, 2017
healther pushed a commit to electronicvisions/spack that referenced this pull request Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants