Skip to content

protobuf: add 21.1#31249

Merged
adamjstewart merged 1 commit intospack:developfrom
mathstuf:protobuf-21.1
Jun 23, 2022
Merged

protobuf: add 21.1#31249
adamjstewart merged 1 commit intospack:developfrom
mathstuf:protobuf-21.1

Conversation

@mathstuf
Copy link
Copy Markdown
Contributor

Older versions have compile errors under newer compilers (e.g., gcc-12).

Older versions have compile errors under newer compilers (e.g., gcc-12).
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jun 22, 2022

Hi @mathstuf! I noticed that the following package(s) don't yet have maintainers:

  • protobuf

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['mathstuf']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame protobuf

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fun. The latest version of py-protobuf broke pretty much every DL library (protocolbuffers/protobuf#10051), so I can't imagine what a huge change in versioning scheme will do.

@adamjstewart adamjstewart self-assigned this Jun 22, 2022
@adamjstewart adamjstewart enabled auto-merge (squash) June 22, 2022 23:25
@adamjstewart adamjstewart merged commit 31d89e8 into spack:develop Jun 23, 2022
@mathstuf mathstuf deleted the protobuf-21.1 branch June 23, 2022 12:07
bhatiaharsh pushed a commit to bhatiaharsh/spack that referenced this pull request Aug 8, 2022
Older versions have compile errors under newer compilers (e.g., gcc-12).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants