Skip to content

relocation: x-pie-executable's needs relocation#31248

Merged
eugeneswalker merged 1 commit intospack:developfrom
eugeneswalker:relocate-x-pie-executables
Jun 22, 2022
Merged

relocation: x-pie-executable's needs relocation#31248
eugeneswalker merged 1 commit intospack:developfrom
eugeneswalker:relocate-x-pie-executables

Conversation

@eugeneswalker
Copy link
Copy Markdown
Contributor

@eugeneswalker eugeneswalker commented Jun 22, 2022 •
edited
Loading

x-pie-executables need relocation.

x-pie-executable is one of the mime types returned by file on Ubuntu 22.04 for some of the files that need to be marked as relocatable when creating a binary cache.

Without this PR:

$> spack python
>>> import spack.relocate as relocate
>>> m1, m2 = relocate.mime_type('.../pkgconf-1.8.0-6euhi2dwrqhctqjxmsg4na3yzrpka736/bin/pkgconf')
>>> (m1, m2)
('application', 'x-pie-executable')
>>> relocate.needs_binary_relocation(m1, m2)
False

With this PR:

$> spack python
>>> import spack.relocate as relocate
>>> m1, m2 = relocate.mime_type('.../pkgconf-1.8.0-6euhi2dwrqhctqjxmsg4na3yzrpka736/bin/pkgconf')
>>> relocate.needs_binary_relocation(m1, m2)
True

Will help or entirely fix #31241, to be determined if this PR alone is enough.

FYI @scottwittenburg @wspear @gartung

@eugeneswalker eugeneswalker added buildcache binary-packages e4s pipelines Issues related to spack's pipeline features labels Jun 22, 2022
@eugeneswalker eugeneswalker force-pushed the relocate-x-pie-executables branch from e053729 to 6463b44 Compare June 22, 2022 22:23
@eugeneswalker eugeneswalker changed the title relocation: x-pie-executable needs relocation relocation: x-pie-executable's needs relocation Jun 22, 2022
wspear
wspear approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wspear wspear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@eugeneswalker eugeneswalker enabled auto-merge (squash) June 22, 2022 22:55
@eugeneswalker eugeneswalker merged commit 7ef52ac into spack:develop Jun 22, 2022
bhatiaharsh pushed a commit to bhatiaharsh/spack that referenced this pull request Aug 8, 2022
@eugeneswalker @bhatiaharsh
relocation: x-pie-executable needs relocation (spack#31248)
592af2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wspear wspear wspear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

binary-packages buildcache e4s pipelines Issues related to spack's pipeline features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

buildcache relocation: rpath not re-written correctly

2 participants

@eugeneswalker @wspear