OpenMPI disable wrapper-runpath when wrapper-rpath is disabled#31221
Merged
tldahlgren merged 3 commits intospack:developfrom Jun 22, 2022
nicholas-sly:develop
Merged
OpenMPI disable wrapper-runpath when wrapper-rpath is disabled#31221tldahlgren merged 3 commits intospack:developfrom nicholas-sly:develop
tldahlgren merged 3 commits intospack:developfrom
nicholas-sly:develop
Conversation
|
@naughtont3 can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
hppritcha
approved these changes
Jun 21, 2022
tldahlgren
approved these changes
Jun 22, 2022
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
… build time error. (spack#31221) Co-authored-by: Nicholas Cameron Sly <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenMPI build throws an error if wrapper-runpath is not disabled but wrapper-rpath is. Adding this disable-wrapper-runpath keeps the error from occurring. Additional work will be necessary for enabling Spack to build an OpenMPI with wrapper-runpath enabled as both branches of the wrapper-rpath variant conditional now explicitly disable wrapper-runpath, but that will be left to someone else if it is required. This error occurs in versions 3.0.5 and later. Having this option did not cause any issues when installing 3.0.4 or 2.1.6.