Skip to content

Pin setuptools version in Github Action Workflows#31118

Merged
alalazo merged 2 commits intospack:developfrom
alalazo:bugfix/pin_setuptools_version
Jun 13, 2022
Merged

Pin setuptools version in Github Action Workflows#31118
alalazo merged 2 commits intospack:developfrom
alalazo:bugfix/pin_setuptools_version

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jun 13, 2022

fixes #31109

Since #31112 needs some fixing for pipelines, this can be a faster solution to keep CI on develop going

Copy link
Copy Markdown
Contributor

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I saw a comment from Todd where he likewise proposed to pin it.

@alalazo alalazo enabled auto-merge (squash) June 13, 2022 18:09
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Jun 13, 2022

This will fix develop, but will still break for people with local venv doing:

$ pip install -U pip setuptools
$ spack style 

So, after that I'll try to make #31112 work too.

@alalazo alalazo disabled auto-merge June 13, 2022 19:08
@alalazo alalazo merged commit 7d96a0a into spack:develop Jun 13, 2022
@alalazo alalazo deleted the bugfix/pin_setuptools_version branch June 13, 2022 19:09
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Jun 13, 2022

One pipeline generation job was apparently stuck. I went ahead and force merged.

alalazo added a commit to alalazo/spack that referenced this pull request Jun 14, 2022
alalazo added a commit to alalazo/spack that referenced this pull request Jun 15, 2022
alalazo added a commit that referenced this pull request Jul 20, 2022
bhatiaharsh pushed a commit to bhatiaharsh/spack that referenced this pull request Aug 8, 2022
vjranagit pushed a commit to vjranagit/spack that referenced this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style checks are currently broken on develop

2 participants