New packages: py-ford and dependencies#31107
New packages: py-ford and dependencies#31107adamjstewart merged 19 commits intospack:developfrom lizzyd710:add-ford
Conversation
|
Are there certain workflows missing from the repo that the checks are trying to find? The logs mention some files that are supposed to be in github-actions-v0.2 (linking to the directory at the last commit at the time of writing this) but in my fork and the upstream, it doesn't exist. |
|
FWIW. The failing style checks (aside from some odd sort issues) are: |
|
Is the import statement being flagged in the style check just a result of some weirdness happening behind the scenes, or do I actually have to change it? I just used what was given when I ran |
Unfortunately, it has to be changed to pass the check. That command provides a template with things that need to be filled in or removed. If it's off then that needs to be adjusted. (I'll take a look.) |
|
From the output of the GitHub action I can't really tell what change I need to make--do you have an example of what a correct import placement would look like? I thought it looked fine since I checked other packages and it looked similar, but maybe I missed something. |
|
|
I can't tell why it's failing these tests. The only thing that I can understand is the line that says it can't find the package |
|
The python 2.7 checks remind me of some failures yesterday that were fixed. Can you rebase to develop? (One option is to click the |
|
The reason you're seeing your new packages in tests is that they are automatically pulled into some existing unit tests. |
|
@adamjstewart @alalazo Do either of you know why this PR is having problems with the unit tests (esp. 2.7)? |
|
No idea, but I'm seeing the same issue in #30916 so I would also love to know why. |
|
P.S. Remind me to review the Python packages before this is merged. |
Just added you as a reviewer. That should help. 😉 |
* Created package * Finished creating package
* Created package and started to add info * Removed unneeded global/install options
For some reason, the py-markdown-include package.py was in a UTF-8 charset when all my other package files were in ASCII. When I fixed it (see latest commit) then everything worked fine. |
tldahlgren
left a comment
There was a problem hiding this comment.
LGTM. Deferring merge decision until @adamjstewart has a chance to review and, preferably, at least @wscullin.
Co-authored-by: Adam J. Stewart <[email protected]>
Co-authored-by: Adam J. Stewart <[email protected]>
tldahlgren
left a comment
There was a problem hiding this comment.
Re-confirmed sha256. Deferring merge until @adamjstewart has a chance to revisit.
* Created package and added description * Add py-markdown-include * Created package * Finished creating package * Added py-md-environ * Added build dependencies * Added other deps * Add python-markdown-math (#4) * Created package and started to add info * Removed unneeded global/install options * Figured out version spec for markdown-math * Removed type=build from unnecessary dependencies * Removed unneeded install/global options, added version spec to dependency * Added wscullin as interim maintainer for packages * Fixed style issues * Took care of trailing whitespace * Removed comment line before imports * Changed file charset to match other packages * Update var/spack/repos/builtin/packages/py-ford/package.py Co-authored-by: Adam J. Stewart <[email protected]> * Update var/spack/repos/builtin/packages/py-ford/package.py Co-authored-by: Adam J. Stewart <[email protected]> * Removed test dependency after review feedback * Added new 6.1.12 version to py-ford Co-authored-by: Seth R. Johnson <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]>
This PR adds the Ford documentation framework along with necessary dependencies that didn't already have spack packages:
Leaving this as a draft PR until I get the maintainers squared away for the packages. In the meantime, for the tagged creators of these libraries/packages, please indicate if you are willing to be tagged as a maintainer for these spack packages.