llvm: make "omp_as_runtime" variant conditional#30782
Merged
haampie merged 1 commit intospack:developfrom May 23, 2022
Merged
Conversation
fixes spack#30700 To avoid clingo adding penalties for not using the default value for a variant, it's better to model the variant as conditional where possible.
Member
Author
|
@manuelakuhn This should fix your issue. Can you confirm? |
Member
|
Yes, I can confirm. With this |
haampie
approved these changes
May 23, 2022
Contributor
|
Excellent, thank you for that. If we'd had the mechanism before this that's how it should always have been. |
iarspider
pushed a commit
to iarspider/spack
that referenced
this pull request
May 30, 2022
fixes spack#30700 To avoid clingo adding penalties for not using the default value for a variant, it's better to model the variant as conditional where possible.
skosukhin
added a commit
to skosukhin/spack
that referenced
this pull request
Jun 10, 2022
haralmha
pushed a commit
to key4hep/spack
that referenced
this pull request
Jun 28, 2022
fixes spack#30700 To avoid clingo adding penalties for not using the default value for a variant, it's better to model the variant as conditional where possible.
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
fixes spack#30700 To avoid clingo adding penalties for not using the default value for a variant, it's better to model the variant as conditional where possible.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #30700
To avoid
clingoadding penalties for not using the default value for a variant, it's better to model the variant as conditional where possible.