Skip to content

gplates: add v2.3.0#30676

Merged
michaelkuhn merged 3 commits intospack:developfrom
adamjstewart:packages/gplates
May 24, 2022
Merged

gplates: add v2.3.0#30676
michaelkuhn merged 3 commits intospack:developfrom
adamjstewart:packages/gplates

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

@michaelkuhn can you help test this? You're the only one who's ever contributed to this package. I especially want to see if the boost variants are sufficient and if the package can be built with the latest version of GDAL.

I'm deprecating GDAL 1 and 2 in #30668 and am trying to see if the latest version of gplates works with GDAL 3 yet. I tried compiling on macOS but QWT is built as a framework so gplates' cmake can't find it. I don't know enough about QMake to build a non-framework version of QWT.

P.S. Are you okay with removing the old gplates versions? The only disadvantage of the latest version is that it requires manual download now. But GDAL 1 and Python 2 are long since dead so modern version support is probably more important.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented May 14, 2022

Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

  • gplates

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['adamjstewart']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame gplates

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@adamjstewart
Copy link
Copy Markdown
Member Author

Ping @michaelkuhn

@michaelkuhn
Copy link
Copy Markdown
Member

I also wanted to test the older versions but couldn't find the respective source tarballs. Are they still available somewhere or is this why you marked them as deprecated?

@adamjstewart
Copy link
Copy Markdown
Member Author

I marked them as deprecated because they depend on GDAL 1 and 2, which I'm deprecating in #30668 and will remove shortly after the 0.18 release. But the fact that they are no longer available for download is another good reason to deprecate them. I didn't look too hard to figure out where they could be downloaded from, but given that newer versions require manual download I wouldn't be surprised if older versions do now too.

Copy link
Copy Markdown
Member

@michaelkuhn michaelkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds on CentOS 8 with GCC 12.1, 11.3 and 8.5.

@michaelkuhn michaelkuhn merged commit 95b03e7 into spack:develop May 24, 2022
@adamjstewart adamjstewart deleted the packages/gplates branch May 24, 2022 06:24
iarspider pushed a commit to iarspider/spack that referenced this pull request May 30, 2022
bhatiaharsh pushed a commit to bhatiaharsh/spack that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants