Conversation
|
Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers = ['adamjstewart']If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame gplatesThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
|
Ping @michaelkuhn |
|
I also wanted to test the older versions but couldn't find the respective source tarballs. Are they still available somewhere or is this why you marked them as deprecated? |
|
I marked them as deprecated because they depend on GDAL 1 and 2, which I'm deprecating in #30668 and will remove shortly after the 0.18 release. But the fact that they are no longer available for download is another good reason to deprecate them. I didn't look too hard to figure out where they could be downloaded from, but given that newer versions require manual download I wouldn't be surprised if older versions do now too. |
michaelkuhn
left a comment
There was a problem hiding this comment.
LGTM and builds on CentOS 8 with GCC 12.1, 11.3 and 8.5.
@michaelkuhn can you help test this? You're the only one who's ever contributed to this package. I especially want to see if the boost variants are sufficient and if the package can be built with the latest version of GDAL.
I'm deprecating GDAL 1 and 2 in #30668 and am trying to see if the latest version of gplates works with GDAL 3 yet. I tried compiling on macOS but QWT is built as a framework so gplates' cmake can't find it. I don't know enough about QMake to build a non-framework version of QWT.
P.S. Are you okay with removing the old gplates versions? The only disadvantage of the latest version is that it requires manual download now. But GDAL 1 and Python 2 are long since dead so modern version support is probably more important.