tutorial stack: allow deprecated versions#30648
Conversation
|
@becker33 @alalazo @scottwittenburg: this should supersede #30148 - I think it's better to keep the tutorial pipeline running as-is until we update the tutorial than to fix it in CI right now. |
|
Just a heads up, after each minor release (0.18, 0.19, etc.) I'm planning on going through Spack and removing all deprecated versions from all packages. Hopefully that won't cause any issues here. |
scottwittenburg
left a comment
scottwittenburg
left a comment
There was a problem hiding this comment.
If this allows the old version to build in the tutorial pipeline, then I'm happy with it. I'll close #30148.
|
@adamjstewart: I think instead of removing deprecated versions, we need to figure out a better way to deal with them. It's a reproducibility issue to just remove them. |
tgamblin
force-pushed
the
tutorial-allow-deprecated
branch
from
3dc9945 to
063c302
Compare
|
The whole purpose of deprecation is to be able to remove them in future releases without surprising someone. If someone wants to build a deprecated/removed version, they can either use an older version of Spack or offer to help maintain the package. Especially for packages with changing build systems it can drastically increase package complexity to maintain both. |
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Hope I'm not reading indentation wrong
| # allow deprecated versions in concretizations | ||
| deprecated: true | ||
|
|
There was a problem hiding this comment.
| # allow deprecated versions in concretizations | |
| deprecated: true | |
| # allow deprecated versions in concretizations | |
| deprecated: true | |
There are three concerns here -- package maintenance, CVE's, and reproducibility. Right now we're marking a lot of things deprecated for CVE's -- which is good -- but I don't think that should make something an automatic candidate for deletion given that someone may have a lock file for that version that they need to reproduce. Without a solution for that, we shouldn't be removing anything but really old versions. |
For tutorial builds, we should continue to allow deprecated builds to be installed. We can update them as needed when we update the tutorial, but we don't need to correct them immediately on deprecation in CI. - [x] add `deprecated:true` to tutorial `spack.yaml` config.
tgamblin
force-pushed
the
tutorial-allow-deprecated
branch
from
063c302 to
3f465f5
Compare
|
@zackgalbreath @scottwittenburg this seems to be "Pending — waiting for base develop commit pipeline to succeed", but the corresponding |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Ugh, this is so frustrating, I'm sorry. Thanks for the heads up though. I wonder if you would copy the link to the supposedly still running develop pipeline and paste it into the comment in the future, we could search for information about that particular pipeline after the fact. I'm not sure it would end up providing us with the all info we need, but there's a chance it could help. If you think of it. |
For tutorial builds, we should continue to allow deprecated builds to be installed. We can update them as needed when we update the tutorial, but we don't need to correct them immediately on deprecation in CI. - [x] add `deprecated:true` to tutorial `spack.yaml` config.
6 participants
Closes #30148.
For tutorial builds, we should continue to allow deprecated builds to be installed. We can update them as needed when we update the tutorial, but we don't need to correct them immediately on deprecation in CI.
deprecated:trueto tutorialspack.yamlconfig.