Boost: add conditional variants by hainest · Pull Request #30627 · spack/spack

hainest · 2022-05-11T19:55:13Z

Fixes #1486
Fixes #11467
Closes #31237
Fixes #30663

TODO

Remove all_libs.
I think this can be done with something like [v.lib for v in self.variants if v.enabled] and then call self.libs() in install (at for lib in Boost.all_libs: around line 692).
Check version ranges for the other variants
boost@master does not build on develop.
I believe this is due to the if not with_libs check in install. I have not verified this yet. I will post build error messages later.
There are many b2 properties/features we don't support. See Add support for alternate boost-context backends #30496

@trws @alalazo @eugeneswalker @wspear @eschnett @asarkar-parsys

hainest · 2022-05-13T18:11:21Z

There are many b2 properties/features we don't support.

boost@master. I have no idea how many of these are useful. TBD.

$ find . -iname "*jamfile*" -exec grep -iP "\s*feature\.feature" {} \; -exec echo {} \; -exec echo "" \;
feature.feature phoenix-limit : : free ;
./libs/phoenix/preprocess/Jamfile.v2

feature.feature iterator_debugging
./libs/accumulators/test/Jamfile.v2

feature.feature wavetool 
./libs/wave/tool/build/Jamfile.v2

feature.feature boost.beast.allow-deprecated : on off : propagated composite ;
feature.feature boost.beast.separate-compilation : on off : propagated composite ;
./libs/beast/Jamfile

feature.feature segmented-stacks : on : optional propagated composite ;
feature.feature htm : tsx : optional propagated composite ;
feature.feature valgrind : on : optional propagated composite ;
feature.feature binary-format
feature.feature abi
feature.feature context-impl
./libs/context/build/Jamfile.v2

feature.feature numa : on : optional propagated composite ;
./libs/fiber/build/Jamfile.v2

feature.feature boost.nowide.lfs : auto no : optional propagated ;
./libs/nowide/build/Jamfile.v2

feature.feature nowchar : on :
./libs/lexical_cast/test/Jamfile.v2

feature.feature fusion-limit : : free ;
./libs/fusion/preprocess/Jamfile.v2

feature.feature boost.locale.iconv : on off : optional propagated ;
feature.feature boost.locale.icu : on off :  optional propagated ;
feature.feature boost.locale.posix : on off : optional propagated ;
feature.feature boost.locale.std : on off : optional propagated ;
feature.feature boost.locale.winapi : on off : optional propagated ;
./libs/locale/build/Jamfile.v2

feature.feature <generate-include-all-order> : forward reverse : incidental ;
./libs/units/test_headers/Jamfile.v2

feature.feature <generate-include-all-order> : forward reverse : incidental ;
./libs/spirit/repository/test/test_headers/Jamfile

feature.feature <generate-include-all-order> : forward reverse : incidental ;
./libs/spirit/test/test_headers/Jamfile

    feature.feature known-warnings : hide show : incidental propagated ;
./libs/spirit/Jamfile

hainest · 2022-07-01T01:56:17Z

@me add test from #30719 (comment)

alalazo · 2023-02-21T06:29:22Z

@hainest I added this one to the v0.20.0 which should be completed roughly for ISC23. Let me know if I can help pushing this forward.

hainest · 2023-02-21T18:52:55Z

@alalazo All of the code changes are done (I think). I've been trying to build all of the packages that depend on Boost to make sure there are no breakages, but some of them just don't build and I've not had a chance to look at why. I will leave it to you to decide if that's a barrier to merging this.

It's been discussed before, but I want to make sure I enunciate this. By far, the biggest change with this PR is that it's now impossible to request a library/feature that doesn't exist in a particular version of boost.

The current behavior is

$ spack spec [email protected]+signals
Input spec
--------------------------------
[email protected]+signals

Concretized
--------------------------------
[email protected] ... +signals ...

but now will fail to concretize because signals was removed in 1.68.0. However, it is my contention that the new behavior is correct as the current behavior leads to possible spec reuse when the signals library actually wasn't installed.

hainest · 2023-03-01T23:29:59Z

@spackbot re-run pipeline

spackbot-app · 2023-03-01T23:30:05Z

I've started that pipeline for you!

Many libraries now require c++11, so it's easier to just make the entire package require c++11.

b2 already quotes them, so passing multiple values causes them to be passed to the compiler as a quoted string like '-fFoo -fBar'.

yap and hana are enabled by default in 1.65.0, but require c++14.

This was introduced by 530639e.

This technically adds an additional check for MPI, but it makes it clearer as to why this is needed. In the even that both threading types are wanted, it will invoke `b2 --install` only once.

There's no need to apply patches that don't pertain to the current set of variants.

github-actions · 2025-11-02T01:51:21Z

This pull request has been automatically marked as stale because it has not had any activity in the last 6 months. It will be closed in 30 days if there is no further activity.

If the pull request is waiting for a reply from reviewers, feel free to ping them as a reminder. If it is waiting and has no assigned reviewer, feel free to ping @spack/spack-releasers or simply leave a comment saying this should not be marked stale. This will reset the pull request's stale state.

To get more eyes on your pull request, you can post a link in the #pull-requests channel of the Spack Slack.
Thank you for your contributions!

github-actions · 2025-12-03T01:50:56Z

This pull request was closed because it had no activity for 30 days after being marked stale. If you feel this is in error, please feel free to reopen this pull request.

spackbot-app bot added new-variant update-package labels May 11, 2022

hainest force-pushed the thaines/boost_conditional_variants branch from 98bf872 to 3afdfb7 Compare May 11, 2022 20:00

This was referenced May 13, 2022

Feature/composed boost pkg deps p3 #28961

Merged

boost: do not add the context-impl option for version below 1.65.0 #30719

Merged

hainest mentioned this pull request Jun 23, 2022

boost: Remove libs json and nowide if not supported by boost version #31238

Closed

payerle mentioned this pull request Jul 12, 2022

Installation issue: boost #31237

Closed

4 tasks

hainest mentioned this pull request Sep 6, 2022

Boost: Add constraints for library variants based on version available #32517

Closed

hainest force-pushed the thaines/boost_conditional_variants branch from d4a635e to a1e9820 Compare November 24, 2022 01:03

hainest force-pushed the thaines/boost_conditional_variants branch from a1e9820 to 83a44b7 Compare December 23, 2022 00:57

hainest force-pushed the thaines/boost_conditional_variants branch 2 times, most recently from bd1ff4f to dc1917a Compare January 23, 2023 15:45

alalazo added this to the v0.20.0 milestone Feb 20, 2023

hainest force-pushed the thaines/boost_conditional_variants branch from d9d89b9 to 74d15ee Compare February 21, 2023 18:01

hainest force-pushed the thaines/boost_conditional_variants branch from 7605f74 to 98e493b Compare February 21, 2023 18:59

hainest mentioned this pull request Apr 5, 2023

Different variants (default values) depending on SPACK release #35236

Closed

3 tasks

hainest force-pushed the thaines/boost_conditional_variants branch 2 times, most recently from b0d6b1a to fa98404 Compare April 14, 2023 19:37

alalazo self-assigned this May 3, 2023

alalazo changed the title ~~[WIP] Boost: add conditional variants~~ Boost: add conditional variants May 3, 2023

alalazo modified the milestones: v0.20.0, v0.21.0 May 11, 2023

alalazo removed this from the v0.21.0 milestone Jun 7, 2023

hainest force-pushed the thaines/boost_conditional_variants branch from fa98404 to 35baeca Compare March 13, 2024 19:05

hainest added 24 commits May 5, 2025 18:21

Add updates from 1.82.0 release notes

6adb541

Add updates from 1.83.0 release notes

4b5464b

Add updates from 1.84.0 release notes

83baaf7

Many libraries now require c++11, so it's easier to just make the entire package require c++11.

Add updates from 1.85.0 release notes

0097925

Add updates from 1.86.0 release notes

5a20152

Add updates from 1.87.0 release notes

e846372

Don't double-quote cxxflags passed to b2

840060f

b2 already quotes them, so passing multiple values causes them to be passed to the compiler as a quoted string like '-fFoo -fBar'.

sarus: update Boost dependency

2f8b4fa

yap and hana are enabled by default in 1.65.0, but require c++14.

Remove with_default_variants for packages with explicit dependence

4d3371d

Remove with_default_variants for packages with implicit dependence

3e11313

Remove with_default_variants

5c1a00a

Add README

da0028b

Use 'spec.satisfies' instead of 'in spec'

1055f33

This was introduced by 530639e.

Extract patch() into patches.py

469bc88

cleanup conflicts

8a4f81b

Extract toolset

f55d08e

Refactor bootstrapping

f90b743

Use boost.io for source downloads

3fa35f5

Move add_buildopt_symlinks out of the way

a3de168

Refactor bjam

b045e5b

Make MPI install process more explicit

cf31181

This technically adds an additional check for MPI, but it makes it clearer as to why this is needed. In the even that both threading types are wanted, it will invoke `b2 --install` only once.

Improve constraints on patches

1b27754

There's no need to apply patches that don't pertain to the current set of variants.

Add tests

22e9abb

Only patch numpy when the variant is active

200bcfe

hainest force-pushed the thaines/boost_conditional_variants branch from 11e1062 to 200bcfe Compare May 5, 2025 23:21

github-actions bot added the stale label Nov 2, 2025

hainest mentioned this pull request Nov 20, 2025

Installation issue: [email protected] spack/spack-packages#2055

Open

4 tasks

github-actions bot closed this Dec 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boost: add conditional variants#30627

Boost: add conditional variants#30627
hainest wants to merge 80 commits intospack:developfrom
hainest:thaines/boost_conditional_variants

hainest commented May 11, 2022 •

edited

Loading

Uh oh!

hainest commented May 13, 2022

Uh oh!

hainest commented Jul 1, 2022

Uh oh!

alalazo commented Feb 21, 2023

Uh oh!

hainest commented Feb 21, 2023

Uh oh!

hainest commented Mar 1, 2023

Uh oh!

spackbot-app bot commented Mar 1, 2023

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

hainest commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hainest commented May 13, 2022

Uh oh!

hainest commented Jul 1, 2022

Uh oh!

alalazo commented Feb 21, 2023

Uh oh!

hainest commented Feb 21, 2023

Uh oh!

hainest commented Mar 1, 2023

Uh oh!

spackbot-app bot commented Mar 1, 2023

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hainest commented May 11, 2022 •

edited

Loading