Eigen: Turn on BUILD_TESTING for build to complete#30528
Merged
alalazo merged 3 commits intospack:developfrom May 6, 2022
Merged
Eigen: Turn on BUILD_TESTING for build to complete#30528alalazo merged 3 commits intospack:developfrom
alalazo merged 3 commits intospack:developfrom
Conversation
alalazo
requested changes
May 6, 2022
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
A very minor request to use define and avoid the else part of the conditional.
Co-authored-by: Massimiliano Culpo <[email protected]>
alalazo
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this bug: https://gitlab.com/libeigen/eigen/-/issues/1656
A recent change to spack's CMakePackage has caused CMake packages to default to using
-DBUILD_TESTING:BOOL=OFF, which has caused this issue.