Skip to content

Use gccgo to bootstrap go on aarch64#30350

Merged
alalazo merged 5 commits intospack:developfrom
rgmiller:develop
May 4, 2022
Merged

Use gccgo to bootstrap go on aarch64#30350
alalazo merged 5 commits intospack:developfrom
rgmiller:develop

Conversation

@rgmiller
Copy link
Copy Markdown
Contributor

@rgmiller rgmiller commented Apr 27, 2022

fixes #14900

This PR essentially reverts the go and go-bootstrap changes from pull #28850 so that users on aarch64 platforms can bootstrap go using gccgo. Also, it adds checks for the proper versions of gcc in order to address the issue in golang/go#47771.

The go-bootstrap package doesn't work on aarch64 platforms, so the only way
to build Go is to use gccgo.

Also, some versions of gccgo have a bug that prevents them from compiling
go (see golang/go#47771), so this patch limits gcc to versions newer than
10.4.0 or 11.3.0.
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Apr 27, 2022

Hi @rgmiller! I noticed that the following package(s) don't yet have maintainers:

  • go-bootstrap

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['rgmiller']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame go-bootstrap

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@spackbot-app spackbot-app bot requested a review from alecbcs April 27, 2022 22:14
Two minor whitespace changes to fix Flake8 checks.
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor changes, but otherwise LGTM.

rgmiller and others added 2 commits May 4, 2022 09:19
Minor change to message text

Co-authored-by: Massimiliano Culpo <[email protected]>
Fix spelling error in comment

Co-authored-by: Massimiliano Culpo <[email protected]>
@rgmiller
Copy link
Copy Markdown
Contributor Author

rgmiller commented May 4, 2022

It looks like the style checks failed trying to install clingo-bootstrap. I'm assuming this is a temporary glitch with the GitHub action. Is there any way to force the style check to run again?

Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the most obvious error message, but that was a symptom of this syntax error - sorry I didn't catch that on the spot while reviewing 🙂

Fix syntax error in message string

Co-authored-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support aarch64 for go-bootstrap/go

2 participants