Skip to content

gitlab ci: replace deprecated zlib in tutorial#30148

Closed
scottwittenburg wants to merge 1 commit intospack:developfrom
scottwittenburg:tutorial-remove-deprecated-version
Closed

gitlab ci: replace deprecated zlib in tutorial#30148
scottwittenburg wants to merge 1 commit intospack:developfrom
scottwittenburg:tutorial-remove-deprecated-version

Conversation

@scottwittenburg
Copy link
Copy Markdown
Contributor

The spack tutorial refers specifically to version 1.2.8 of zlib in multiple places, but since that version is deprecated now, it can no longer be built without --deprecated.

@spackbot-app spackbot-app bot added the gitlab Issues related to gitlab integration label Apr 18, 2022
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Apr 19, 2022

@scottwittenburg Did you double check the tutorial? I think in a few places the v1.2.8 was used in place of the preferred one to show that you can pick and choose whichever version you want (so using the preferred v1.2.12 version won't make sense there).

@alalazo alalazo requested review from alalazo and tldahlgren April 19, 2022 07:00
@alalazo alalazo self-assigned this Apr 19, 2022
@alalazo alalazo removed the request for review from tldahlgren April 19, 2022 07:00
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With respect to the comment above, see for instance how v1.2.8 is used here

@scottwittenburg
Copy link
Copy Markdown
Contributor Author

@alalazo Yes I took a quick look at the tutorial, but I wasn't 100% sure about the intent of picking 1.2.8. But it sounds like we might be in trouble regarding that particular goal of the tutorial, because at the moment, the preferred version of zlib is the only version that is not deprecated. Any thoughts on what should be done? Right now, if we try to build zlib in the pipeline, it fails, and we're only avoiding that because zlib is already in the mirror and its hash hasn't changed.

@scottwittenburg
Copy link
Copy Markdown
Contributor Author

@zackgalbreath

@becker33
Copy link
Copy Markdown
Member

I think we should not deprecate those versions, I think it was overeager to deprecate them.

An alternative is we could just configure the tutorial to be okay with deprecated versions.

@scottwittenburg
Copy link
Copy Markdown
Contributor Author

Closing this as #30648 is a better approach for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitlab Issues related to gitlab integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants