OpenSSL enable quotes in build arguments#29928
Merged
scheibelp merged 3 commits intospack:developfrom Apr 19, 2022
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
scheibelp
reviewed
Apr 7, 2022
4 tasks
Member
|
Can you please fix the regression you've introduced in cf1349b#diff-1265afdd8d01e4176b1c1551b0139aee72410af8357e81acfd8a964bb41e35ab? You've basically reversed #18024. |
Contributor
Author
|
johnwparent
force-pushed
the
fixup-openssl-win
branch
from
a389297 to
246cbb0
Compare
Contributor
Author
|
@haampie Can you verify these changes now resolve your issue? |
scheibelp
approved these changes
Apr 19, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to support building on Windows due to spaces in common compiler install directories and how nmake arguments are parsed.
Addresses #29576 depends on #29905