Fixup NASM install on Windows#29905
Merged
scheibelp merged 1 commit intospack:developfrom Apr 14, 2022
Merged
Conversation
|
Hi @johnwparent! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers = ['johnwparent']If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame nasmThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
4 tasks
johnwparent
force-pushed
the
fixup-nasm-on-win
branch
from
f90e736 to
4b8cf23
Compare
Don't rely on NASM's nmake to export install target Spack handles NASM installation Install tree structure mimics NASM Windows installer behavior Ensure build runs on Windows Fold build into install phase
johnwparent
force-pushed
the
fixup-nasm-on-win
branch
from
4b8cf23 to
15f2938
Compare
scheibelp
approved these changes
Apr 14, 2022
joequant
pushed a commit
to hkphysics/spack
that referenced
this pull request
Apr 17, 2022
* Don't rely on NASM's nmake to export install target. Spack now handles NASM installation; the install tree structure mimics NASM Windows installer behavior. * Add dependency on perl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't rely on NASM's nmake to export install target
Spack handles NASM installation
Install tree structure mimics NASM Windows installer behavior